30380 - blockquote is display: block

Status: VERIFIED FIXED

(Core :: DOM: Serializers, defect, P3)

Description

[Ben Bucksch (:BenB)]

Reproduce:
1. Insert the following HTML into the editor:
bla<blockquote>foo</blockquote>

Actual result:
bla    foo

Expected result:
bla
    foo

Additional Comments:
propable as easy to fix as an |EnsureVerticalSpace| at the right place.

Comment 1

[Akkana Peck]

Thanks -- I should also put this in the output tests.

Comment 2

[Akkana Peck]

Ugh, not that easy.

It's easy to get the newline in -- as you said, just an EnsureVerticalSpace in
the blockquote case of OpenContainer.  But then we get:

    blah
    foo

because the line isn't flushed before adding the indent.  (If you put a <br>
after blah, then it works correctly.)

Cc'ing Daniel since it sounds similar to some of the changes for 17883 (but this
happens both with and without his latest patch for that bug).

Comment 3

[Daniel Bratell]

It is a missing EnsureVerticalSpace. Maybe you just put the command at the wrong 
place, below the update of the indent. The following works for me in the editor:

    else if (type == eHTMLTag_blockquote)
    {
+     EnsureVerticalSpace(0);
+
      // Find out whether it's a type=cite, and insert "> " instead.
      // Eventually we should get the value of the pref controlling citations,
      // and handle AOL-style citations as well.

Comment 4

[Akkana Peck]

Yes, this fixes it.  Fix in hand, will check in when the tree opens.

Comment 5

[Akkana Peck]

Fixed.

Comment 6

[sujay]

verified in 3/14 build.