30381 - Can't compose mail: contentWindow is not defined

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Akkana Peck]

Seen with a linux debug build updated Friday morning, and with the commercial
build from Friday afternoon.

Run mozilla -compose
  (get an html compose window, though I thought my preference was plaintext)
Click in the To field and type an address
Hit tab
Type a subject
Hit tab
Note no caret; type and it still goes to the subject field.
Click in the content window -- still no caret, still can't type there.

Somewhere along the line, I see on stdout:
JavaScript Error: ReferenceError: contentWindow is not defined

Comment 1

[Akkana Peck]

This happens even if I don't click in the content area first.  Regression,
nominating for beta1.

Comment 2

[Jean-Francois Ducarroz]

if content window isn't defined, that means probably that ender has not been 
initialized and therefore you cannot type into the body of the message. Have you 
tried to open the compose window and then click directly into the body and enter 
some text?

If that doesn't work either, can you provide me the whole content of the 
console. Thanks

I don't see this on my Windows or Mac build.

Comment 3

[Jim Roskind]

PDT+: critical regression (when it is seen).

Comment 4

[Jean-Francois Ducarroz]

Akkana, if you still see the problem Monday moning, let me know and I will come 
to see you as soon as I arrive to the office (around 11 am)

Comment 5

[buster]

I can easily reproduce this on windows NT.  I updated at 8:00pm Sunday night, so 
I have all the latest bits.  Changing OS to all.
I notice that when I run "mozilla -compose", the mail compose window hasn't 
picked up info from prefs.  For example, there are no entries in the "From" 
dropdown list.  If I run "mozilla" and do New > Mail Message, "From" is properly 
filled in.

Comment 6

[Akkana Peck]

I still see this on Monday morning, though now I see the message as an alert box
rather than a console printf.

Comment 7

[(not reading, please use [e-mail] instead)]

just talked to ducarroz over the phone.

I'm taking this bug from him.  the problem is in the command line handling code, 
I'm not opening the compose window the right way.

should be easy enough to fix.

(although I wouldn't consider -compose a beta blocker, but if it has PDT+, I'm 
not going to complain.)

Comment 8

[(not reading, please use [e-mail] instead)]

I think I can have this fixed tonight / tomorrow.

Comment 9

[(not reading, please use [e-mail] instead)]

fix in hand.  seeking review and approval. 

I was using my monster macro incorrectly.  here's the fix:

Index: src/nsMsgComposeService.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/compose/src/nsMsgComposeService.cpp,v
retrieving revision 1.30
diff -r1.30 nsMsgComposeService.cpp
373c373
<
CMDLINEHANDLER_IMPL(nsMsgComposeService,"-compose","general.startup.messengercompose","chrome://messengercompose/content/","Start
with messenger compose.",NS_MSGCOMPOSESTARTUPHANDLER_PROGID,"Messenger Compose
Startup Handler", PR_FALSE, "", PR_TRUE)
---
>
CMDLINEHANDLER_IMPL(nsMsgComposeService,"-compose","general.startup.messengercompose","chrome://messengercompose/content/","Start
with messenger compose.",NS_MSGCOMPOSESTARTUPHANDLER_PROGID,"Messenger Compose
Startup Handler", PR_TRUE, "about:blank", PR_TRUE)

thanks to ducarroz for telling me what the problem was.
(he noticed we were opening the window with OpenChromURL and not OpenWindow in
nsAppRunner.cpp)

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.  r=mscott, a=jar.

Comment 11

[fenella]

linux (2000-03-07-09 M15)
Win32 (2000-03-07-09 M15)
Mac (2000-03-07-08 M15)
This problem has been fixed using the same scenario.