Closed Bug 303812 Opened 19 years ago Closed 19 years ago

[FIX]ASSERTION: Not a URL value! when using invalid url for cursor value

Categories

(Core :: CSS Parsing and Computation, defect, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: martijn.martijn, Assigned: bzbarsky)

References

(
URL
)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

testcase
260 bytes, text/html
Details
Fix
2.15 KB, patch
dbaron
: review+
dbaron
: superreview+
Details | Diff | Splinter Review 
See upcoming testcase. This testcase gives an assertion for me, when loading the
page:
###!!! ASSERTION: Not a URL value!: 'eCSSUnit_URL == mUnit', file c:/mozilla/moz
illa/layout/style/nsCSSValue.cpp, line 353
Keywords: assertion
Attached file testcase — 

  

  



    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix
        — 
          — Splinter Review
      

    


  

  

  


Assignee: dbaron → bzbarsky
Status: NEW → ASSIGNED

        Attachment #203624 -
        Flags: superreview?(dbaron)

        Attachment #203624 -
        Flags: review?(dbaron)

    
  
OS: Windows XP → All
Priority: -- → P2
Hardware: PC → All
Summary: ASSERTION: Not a URL value! when using invalid url for cursor value → [FIX]ASSERTION: Not a URL value! when using invalid url for cursor value
Target Milestone: --- → mozilla1.9alpha

    
    

    
  
How does ParseCursor create an array value with a 0th item being something that's not a URL?

  

  



    
    

    
  
It doesn't, but the next time we hit this code (say the next time we're resolving style for this node) the unit is eCSSUnit_Image, since we've already started the load.  In that case we don't really want to StartImageLoad again, which is what we're doing as the code stands.

  

  



    
    

    
  
Comment on attachment 203624 [details] [diff] [review]
Fix

OK, r+sr=dbaron if you add the comment "don't try to restart loads we've already started".

  

  



        Attachment #203624 -
        Flags: superreview?(dbaron)

        Attachment #203624 -
        Flags: superreview+

        Attachment #203624 -
        Flags: review?(dbaron)

        Attachment #203624 -
        Flags: review+

    
    

    
  
Fixed, with that comment added.

  

  


Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
  
Depends on: 425057

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: