[FIX]ASSERTION: Not a URL value! when using invalid url for cursor value

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: bz)

Tracking

({assertion, testcase})

Trunk
mozilla1.9alpha1
assertion, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
See upcoming testcase. This testcase gives an assertion for me, when loading the
page:
###!!! ASSERTION: Not a URL value!: 'eCSSUnit_URL == mUnit', file c:/mozilla/moz
illa/layout/style/nsCSSValue.cpp, line 353
(Reporter)

Updated

12 years ago
Keywords: assertion
(Reporter)

Comment 1

12 years ago
Created attachment 191914 [details]
testcase
Created attachment 203624 [details] [diff] [review]
Fix
Assignee: dbaron → bzbarsky
Status: NEW → ASSIGNED
Attachment #203624 - Flags: superreview?(dbaron)
Attachment #203624 - Flags: review?(dbaron)
OS: Windows XP → All
Priority: -- → P2
Hardware: PC → All
Summary: ASSERTION: Not a URL value! when using invalid url for cursor value → [FIX]ASSERTION: Not a URL value! when using invalid url for cursor value
Target Milestone: --- → mozilla1.9alpha
How does ParseCursor create an array value with a 0th item being something that's not a URL?
It doesn't, but the next time we hit this code (say the next time we're resolving style for this node) the unit is eCSSUnit_Image, since we've already started the load.  In that case we don't really want to StartImageLoad again, which is what we're doing as the code stands.
Comment on attachment 203624 [details] [diff] [review]
Fix

OK, r+sr=dbaron if you add the comment "don't try to restart loads we've already started".
Attachment #203624 - Flags: superreview?(dbaron)
Attachment #203624 - Flags: superreview+
Attachment #203624 - Flags: review?(dbaron)
Attachment #203624 - Flags: review+
Fixed, with that comment added.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Depends on: 425057
You need to log in before you can comment on or make changes to this bug.