303817 - [FIX]const nsAFlatString& GetDocumentTitle() const. May return null. oh really?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P4)

Description

[timeless]

135    * Return the title of the document. May return null.
oh really?
136    */
137   const nsAFlatString& GetDocumentTitle() const
138   {
139     return mDocumentTitle;

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix docs

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 203623 [details] [diff] [review]
Fix docs

+   * Return the title of the document.  May return a void string (one for which
+   * calling .get() returns null) if there is no title for this document).
    */
   const nsString& GetDocumentTitle() const

that comment is wrong. nsString will never return null for .get(), only nsXPIDLString will.

(btw, did you intentionally have parts of the content-id-removal patch in this one?)

Comment 3

[Boris Zbarsky [:bzbarsky]]

> nsString will never return null for .get(), only nsXPIDLString will.

Ah, ok.  I thought that a IS_VOID string would return null.  I'll fix that comment accordingly.

> did you intentionally have parts of the content-id-removal patch 

Nope.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix docs better

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 203734 [details] [diff] [review]
Fix docs better

r+sr=jst

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.