303824 - BugMail should ignore deleted or renamed user accounts

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Frédéric Buclin]

If a user account is deleted or renamed while this user was either in the CC
list of a bug or was the assignee or the QA contact, BugMail.pm is unable to
send any new email relative to this bug because it checks that email addresses
from the bug activity table are valid and returns an error if they are not. So
assuming someone changes his login name (or his account is being deleted by an
administrator) before all emails relative to bugs where his role changed
meanwhile are sent, an error is returned saying:

The name [e-mail] is not a valid username.
Either you misspelled it, or the person has not
registered for a Bugzilla account.

BugMail should ignore these old user accounts for two reasons:
- A deleted account certainly doesn't want to receive any email anymore;
- A renamed account will still receive emails at the new address, so there is no
need to try to send emails to the old email address.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 191920 [details] [diff] [review]
patch, v1

r=wurblzap. It's good to silently ignore invalid bugs_activity data anyway
because of the data being stored as flat strings there.

Comment 3

[Marc Schumann [:Wurblzap]]

Because of bug 282632, the patch doesn't apply cleanly to the 2.20 branch. We'll
need a backport so that bug 303393 can go in.

Comment 4

[Frédéric Buclin]

Attachment: backport for 2.20, v1

Strange enough, BugMail.pm doesn't need to "use Bugzilla::User" despite the use
of login_to_id(). Maybe is it due to this AUTOLOAD section?

Comment 5

[Frédéric Buclin]

Attachment: backport for 2.20, v1.1

Marc and I feel more confident with "use Bugzilla::User" being explicitly
written, even if it works without it.

Comment 6

[Dave Miller [:justdave]]

Ummm, I already filed this bug, and posted a patch on it, several months ago...

/me goes looking for the original bug

Comment 7

[Dave Miller [:justdave]]

ok, found it.  For the record, the bug I'm thinking of is bug 227172, which was
fixed on 2004-05-26, and regressed with the checkin of bug 73665.

Comment 8

[Frédéric Buclin]

tip:

Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.46; previous revision: 1.45
done

2.20rc2:

Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.39.4.1; previous revision: 1.39
done