303841 - When screen reader running, prefer external viewer for full page plugins

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Aaron Leventhal]

Right now we have a lot of accessibility problems with plugins. PDFs are a very
important content type for all users, including screen reader users. Screen
reader vendors generally recommend that their users set IE to launch PDFs
externally. This is a good thing to do in Firefox as well, and we might as well
choose that setting automatically when a screen reader is running.

Comment 1

[Aaron Leventhal]

Attachment: When screen reader is present and loading a plugin, check for external handler and use instead it if it exists

Comment 2

[Aaron Leventhal]

This fixes the last big hole in our VPAT.

It even helps deal with Flash, which does not support MSAA in the Netscape
plugin but does in the external viewer.

We can't detect sighted keyboard-only users, so will have to recommend that they
edit the actions under Options -> Downloads -> View & Edit Actions

Comment 3

[Aaron Leventhal]

Requesting blocking status because I have a patch and it fixes our last big
section 508 hole.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 192004 [details] [diff] [review]
When screen reader is present and loading a plugin, check for external handler and use instead it if it exists

nsWebNavigationInfo.cpp:
+	   mimeService->GetFromTypeAndExtension(aType, EmptyCString(),
+					       getter_AddRefs(mimeInfo));

wrong indentation on the second line

r=biesi

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 192004 [details] [diff] [review]
When screen reader is present and loading a plugin, check for external handler and use instead it if it exists

sr=jst

Comment 6

[Aaron Leventhal]

Checking in docshell/base/Makefile.in;
/cvsroot/mozilla/docshell/base/Makefile.in,v  <--  Makefile.in
new revision: 1.58; previous revision: 1.57
done
Checking in docshell/base/nsWebNavigationInfo.cpp;
/cvsroot/mozilla/docshell/base/nsWebNavigationInfo.cpp,v  <-- 
nsWebNavigationInfo.cpp
new revision: 1.2; previous revision: 1.1
done
Checking in widget/public/nsILookAndFeel.h;
/cvsroot/mozilla/widget/public/nsILookAndFeel.h,v  <--  nsILookAndFeel.h
new revision: 1.47; previous revision: 1.46
done
Checking in widget/src/qt/nsLookAndFeel.cpp;
/cvsroot/mozilla/widget/src/qt/nsLookAndFeel.cpp,v  <--  nsLookAndFeel.cpp
new revision: 1.23; previous revision: 1.22
done
Checking in widget/src/windows/nsLookAndFeel.cpp;
/cvsroot/mozilla/widget/src/windows/nsLookAndFeel.cpp,v  <--  nsLookAndFeel.cpp
new revision: 1.50; previous revision: 1.49
done
Checking in widget/src/xpwidgets/nsXPLookAndFeel.cpp;
/cvsroot/mozilla/widget/src/xpwidgets/nsXPLookAndFeel.cpp,v  <-- 
nsXPLookAndFeel.cpp
new revision: 1.44; previous revision: 1.43
done

Comment 7

[Aaron Leventhal]

This caused bug 340841. Our check to see if an external handler exists does not work.

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381