303863 - "No updates were found for Extensionname" should be "No updates were found"

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Gemal]

looking down a long list of extensions it's hard to see changes since we write:
---
Launchy
No updates were found for Launchy
---

instead of just:
---
Launchy
No updates were found
---


is there really a need to write the extensionname in the update text since it's
just above the update text?

Comment 1

[u88484]

Attachment: patch

patch incase this is decided on to change. donno who to ask for review

Comment 2

[u88484]

Attachment: patch v2.0

Patch includes follwing changes:
-updatingMessage=Looking for updates to %S...
-updateAvailableMessage=A new version of %S (%S) is available.
-updateCompatibilityMessage=A compatibility update has been applied to %S.
-updateNoUpdateMessage=No updates were found for %S.
-updateErrorMessage=An error occurred while trying to find updates for %S.
+updatingMessage=Checking for an update...
+updateAvailableMessage=A new version is available.
+updateCompatibilityMessage=A compatibility update has been applied.
+updateNoUpdateMessage=No updates were found.
+updateErrorMessage=An error occurred while trying to find an update.
-incompatibleUpdateMessage=%S is checking for a compatibility update to %S.
+incompatibleUpdateMessage=%S is checking for a compatibility update.

I thought most of them could do without naming the extension.

who should I ask to review?

Comment 3

[u88484]

Comment on attachment 193779 [details] [diff] [review]
patch v2.0

Sorry if wrong person for review, I donno how to find who reviews which
components.

Comment 4

[u88484]

Comment on attachment 193779 [details] [diff] [review]
patch v2.0

changes done to reduce redundancy in listing the extension name

Comment 5

[Boris Zbarsky [:bzbarsky]]

See http://www.mozilla.org/owners.html and note that this page is linked from
the mozilla.org pages talking about code review...

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

This would have a late l10n impact if accepted as a blocker for Beta2, since the
translated strings would also have to be modified.

Kurt, the list of strings that you updated looks like the right subset to me --
the other strings all really require the name in order to make sense. The only
one I wonder about is:

updateAvailableMessage=A new version is available.

I think that it's important that users get to see the version number to which
they are upgrading before they make the decision to install or not. I can't test
this locally right now (can't find an old extension that's compatible with 1.4
:) but do you know if the UI eventually shows them this information and provides
them with a choice to install or not? I noticed:

itemFormat=%S %S (New version: %S)

which seems to indicate that it does.

Comment 7

[Scott MacGregor]

Comment on attachment 193779 [details] [diff] [review]
patch v2.0

this patch doesn't fix the call sites which would still be trying to fill in
the %S values for these strings which no longer require formatting. Thus it is
incomplete.

Comment 8

[Scott MacGregor]

This is not a stop ship bug. 

However, if a valid, low risk patch appeared in the next few days and our l10n
contact says it is ok, we may consider taking the patch. But it is not a blocker
of the release.

Comment 9

[u88484]

Could someone point me in the right direction to find where these call sites are
or at least one of them? I'm new to all of this and need some help. Thanks

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 193779 [details] [diff] [review]
patch v2.0

minusing for the reasons scott mentioned. a quick search in LXR shows that
caller sites are in nsExtensionManager.js

http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/extensions/src/nsExten
sionManager.js.in#6632

Comment 11

[Robert Strong (they/them - no direct email)]

Fixed on trunk by the checkin for bug 329045. The text may change when the strings are reviewed in bug 308916 but at least for now it is written as "No updates were found".