Closed
Bug 303876
Opened 20 years ago
Closed 20 years ago
Class attribute name should be set in *Stub* elements, not in *ControlStub*
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(1 file)
|
12.35 KB,
patch
|
allan
:
review+
aaronr
:
review+
|
Details | Diff | Splinter Review |
Atm, we set the name of the class attribute in ControlStubs, but because for
example <choices> is not using ControlStubs, it doesn't support class attribute.
So we should be setting the class attribute name in Stubs.
Patch coming.
|
Assignee | |
Comment 1•20 years ago
|
||
This fixes also the bug where one can't QI nsXFormsBindableControlStub to
nsIXFormsControlBase.
Attachment #191957 -
Flags: review?(allan)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #191957 -
Flags: review?(aaronr)
Comment on attachment 191957 [details] [diff] [review]
proposed patch
seems fine, but the nsXFormsCaseElement.cpp bit isn't up to date with the
current tree, of course :)
r=me
Attachment #191957 -
Flags: review?(aaronr) → review+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 191957 [details] [diff] [review]
proposed patch
r=me
Attachment #191957 -
Flags: review?(allan) → review+
|
|
||
Comment 4•20 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•