Closed Bug 303941 Opened 19 years ago Closed 19 years ago

Convert update's link widget to use the existing text-link widget

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: mscott, Assigned: mscott)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

the fix
6.78 KB, patch
bugs
: superreview+
cbeard
: approval1.8b4+
Details | Diff | Splinter Review 
If you are doing an update with Thunderbird and you try to click on one of the
links like "Details" or "Click Here for More Information about this update",
we fail to open the link.

This is because update is using a custom link widget here. We can instead use
the text-link widget which does the same thing but knows how to route non
exposed protocols to the desktop instead of trying to open up browser.xul.
this will block smart update in thunderbird since the links won't work when clicked
Flags: blocking1.8b4?
Attached patch the fix — — Splinter Review 
I haven't been able to properly test this for real yet because none of our
updates are providing URLS for these various text links yet.

I did test this by forcing some of the text links to have hard coded url values
(set from JS), to make sure that the link fires to the right spot.
Attachment #192011 - Flags: superreview?(bugs)
Flags: blocking1.8b4? → blocking1.8b4+
Whiteboard: [needs SR beng]
Comment on attachment 192011 [details] [diff] [review]
the fix

r=ben@mozilla.org
Attachment #192011 - Flags: superreview?(bugs)
Attachment #192011 - Flags: superreview+
Attachment #192011 - Flags: approval1.8b4?
fixed on the trunk. So marking the bug as fixed. Still needs branch approval of
course.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [needs SR beng]
Comment on attachment 192011 [details] [diff] [review]
the fix

pending verification in trunk builds
Attachment #192011 - Flags: approval1.8b4? → approval1.8b4+
I verified this on the 09/01 trunk builds.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: