303944 - Action list in filter editor window has fixed width -> action strings truncated

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jérôme Schell]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8b4) Gecko/20050807 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8b4) Gecko/20050807 Firefox/1.0+

In the filter editor window, the lists of actions in the bottom have a fixed
width. They don't increase during window resizing. When using an en-US version
of Thunderbird this is not a problem. Nevertheless with localized version
strings that are too long for the width of the list are truncated without the
possiblity of seeing them.
I'm attaching a screenshot of the french version of this window to demonstrate
the problem.

Reproducible: Always

Comment 1

[Jérôme Schell]

Attachment: Screenshot of the french version

Screenshot of the french version showing a truncated string.

Comment 2

[Adam Guthrie]

Confirming. Was this an issue before the landing of bug 294094?

Comment 3

[Scott MacGregor]

at the very least we should let the min size of the menu list be an entity like
we do in other parts of the code so localizers can forcee it to be wider.

Comment 4

[Scott MacGregor]

Attachment: possible fix

One way to fix this problem is to allow localizers to specify the min width for
the filter action menu lists like we do for the prefs window and the account
manager.

Comment 5

[[e-mail]]

Attachment: Simpler patch

I worked out that removing the flex="1" and changing the width to a min-width
allows the menulist to size to the popup, but I also had to remove the padding
override otherwise the popup would be 22 (on my system) pixels too narrow.

Comment 6

[Scott MacGregor]

Comment on attachment 192080 [details] [diff] [review]
Simpler patch

Neil this patch worked for most cases. I ran into one problem with it. If you
have a reply template with a huge  subject line, the filter target menu list
for the reply template spills off the edge of the dialog instead of truncating
after a reasonable width.
Maybe we need to put a max-width on the lists to ensure that all of the
elements will fit.

Also, with this change, when shrinking the window, elements run over each other
instead of shrinking to a min width and stopping like it used to. 

I like the idea of the patch, but these two behaviors make it not so good :)

Comment 7

[[e-mail]]

(In reply to comment #6)
>Also, with this change, when shrinking the window, elements run over each other
>instead of shrinking to a min width and stopping like it used to. 
Actually we have this issue even without this change...

Comment 8

[[e-mail]]

Attachment: Tweaked patch

OK, I think this tweak fixes both issues.

Comment 9

[Scott MacGregor]

Comment on attachment 192180 [details] [diff] [review]
Tweaked patch

Almost there Neil. This works great for me. The last issue I see is that the
search criteria menu lists still get smushed together instead of having a min
width like the filter actions. Before this patch, they didn't shrink below a
certain size.

Fix that and r/sr=me and I can drop an a= for the checkin

Comment 10

[[e-mail]]

Attachment: Final tweak?

I hope this meets with your approval ;-)

Comment 11

[Scott MacGregor]

Comment on attachment 192304 [details] [diff] [review]
Final tweak?

yup that fixes all of the edge cases. Thanks Neil.

Comment 12

[[e-mail]]

Fix checked in.

Comment 13

[Simon Paquet [:sipaq]]

Comment on attachment 192046 [details] [diff] [review]
possible fix

This patch was obsoleted by a patch from Neil (see attachment 192304 [details] [diff] [review]), which was checked in.