303948 - Sometimes, thunderbird has trouble with grouped sort

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Andreas Morawietz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050808 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050808 Firefox/1.0+

Sometimes, thunderbird has trouble with "grouped sort".

It shows false descriptions ("yesterday" instead of "today"), so "yesterday" is
displayed twice...

or the + to expand a group isn't visbile or the + is on a message instead of the
description of that group (e.g. "Yesterday") 

or sometimes, it shows some strange characters in descriptions (e.g.: %§$%§"=(=)
In this case, I must restart thunderbird...

I'm sorry, but I can't reproduce this... it happens only sometimes in all
Deerpark builds.

Reproducible: Sometimes

Comment 1

[zug_treno]

Related to bug 287181 and bug 269199?

Comment 2

[Andreas Morawietz]

*** This bug has been marked as a duplicate of 287181 ***

Comment 3

[David :Bienvenu]

Attachment: proposed fix

this could fix a whole raft of problems that are reported when the day changes.
Basically I rebuild the view when the day changes, and a header is
added/changed/deleted (the only notifications I was brave enough to rebuild on
- rebuilding the view during a paint call is probably a bad idea :-) )

Comment 4

[Scott MacGregor]

Comment on attachment 192263 [details] [diff] [review]
proposed fix

Should we be checking rv a lot sooner here. like right after calling
openWithHdrs?

+    nsresult rv = OpenWithHdrs(headers, m_sortType, m_sortOrder, m_viewFlags,
&count);
+    EnableChangeUpdates();
+    if (mTree) 
+      mTree->RowCountChanged(0, GetSize());
+
+    NS_ENSURE_SUCCESS(rv,rv);


I think this is going to fix some of the problems I've had with grouped by sort
too (I filed a bug somewhere a while ago). Sometimes you can even crash when
the grouped view gets out of whack after a day change. I suspect this will fix
that crash too.

Comment 5

[David :Bienvenu]

no, that was intentional - I wanted to turn back on updates for sure (on the off
chance the view was somehow salvagable).