303951 - Make printing use the new interfaces

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Joey Minta]

Print support in Sunbird 0.2 was rather weak, but right now trunk has no print
support whatsoever.  This doesn't block 0.3a1, but it'd be nice to have.

Comment 1

[Joey Minta]

Attachment: use new interfaces

Makes printing use the new interfaces, as well as the HTML export mechanism. 
In the future we may want to have a separate print-exporting tool, but this
gets basic support going again.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Does printing currently work (without the patch)? If so, we shouldn't swtich
until the new exporter van export the different formats printing can handle.

Comment 3

[Joey Minta]

(In reply to comment #2)
> Does printing currently work (without the patch)? If so, we shouldn't swtich
> until the new exporter van export the different formats printing can handle.

http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calPrintEngine.js
322       var calendarEventDisplay
323       // add each calendarEvent
324       dayEventList = eventSource.getEventsForDay( thisDaysDate );

In other words, no, it doesn't currently work.

Comment 4

[MCT]

Any chance of getting this rolled into the trunk? I tried patching the Oct 7
trunk source but it didn't quite work. Really would be good to have some basic
printing back...

Comment 5

[Joey Minta]

Comment on attachment 192024 [details] [diff] [review]
use new interfaces

patch has rotted, removing review request.

Comment 6

[Joey Minta]

Attachment: use new interfaces v2

Updated patch, same as before.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 199174 [details] [diff] [review]
use new interfaces v2

Looks good, but i can't test, due to the lack of a printer.
Please file some followup bugs to add new print layouts (more exporters), to
add a better UI and to stop using a tempfile (and anything else you can come up
with)

Comment 8

[Joey Minta]

patch checked in