#footer span { display: block; } is asking for trouble

RESOLVED WORKSFORME

Status

()

Bugzilla
User Interface
RESOLVED WORKSFORME
13 years ago
12 years ago

People

(Reporter: Jesse Ruderman, Unassigned)

Tracking

Details

(Reporter)

Description

13 years ago
From https://bugzilla.mozilla.org/skins/standard/global.css :

    #footer span
    {
        display: block;
    }

This is asking for trouble.  In particular, if you use Firefox's Find Toolbar on
any https://bugzilla.mozilla.org/ page, search for "s", and click the Highlight
button, the Bugzilla footer explodes because the Find Toolbar adds a <span>
element around every instance of the letter "s".

Firefox is being buggy when it adds the spans (bug 256990), but Bugzilla
shouldn't break every time a browser or bookmarklets or Greasemonkey script adds
some <span> elements to the page.
bug 256990 has been fixed.  This is no longer an issue.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → INVALID
(Reporter)

Comment 2

13 years ago
Bug 256990 was fixed in a hacky way, and this could still be an issue with bookmarklets or Greasemonkey scripts.

What is the purpose of Bugzilla's "#footer span { display: block; }", anyway?  Why not just use DIVs there?
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

Comment 3

12 years ago
There are only divs in the footer. This rule doesn't get applied at all (unless I cannot read the template code correctly). 

Updated

12 years ago
Assignee: myk → ui
Status: REOPENED → NEW

Comment 4

12 years ago
Is this still an issue? I can't find that line in the css anymore.

There is now span elements in the footer (the separators). Was this rule removed when those were added?
(Reporter)

Comment 5

12 years ago
WFM.  The footer seems to be made of LI and DIV elements now.  Firefox's "Highlight All" no longer runs into trouble.
Status: NEW → RESOLVED
Last Resolved: 13 years ago12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.