303966 - #footer span { display: block; } is asking for trouble

Status: RESOLVED WORKSFORME

(Bugzilla :: User Interface, defect)

Description

[Jesse Ruderman]

From https://bugzilla.mozilla.org/skins/standard/global.css :

    #footer span
    {
        display: block;
    }

This is asking for trouble.  In particular, if you use Firefox's Find Toolbar on
any https://bugzilla.mozilla.org/ page, search for "s", and click the Highlight
button, the Bugzilla footer explodes because the Find Toolbar adds a <span>
element around every instance of the letter "s".

Firefox is being buggy when it adds the spans (bug 256990), but Bugzilla
shouldn't break every time a browser or bookmarklets or Greasemonkey script adds
some <span> elements to the page.

Comment 1

[Dave Miller [:justdave]]

bug 256990 has been fixed.  This is no longer an issue.

Comment 2

[Jesse Ruderman]

Bug 256990 was fixed in a hacky way, and this could still be an issue with bookmarklets or Greasemonkey scripts.

What is the purpose of Bugzilla's "#footer span { display: block; }", anyway?  Why not just use DIVs there?

Comment 3

[Bill Barry]

There are only divs in the footer. This rule doesn't get applied at all (unless I cannot read the template code correctly). 

Comment 4

[Bill Barry]

Is this still an issue? I can't find that line in the css anymore.

There is now span elements in the footer (the separators). Was this rule removed when those were added?

Comment 5

[Jesse Ruderman]

WFM.  The footer seems to be made of LI and DIV elements now.  Firefox's "Highlight All" no longer runs into trouble.