303974 - chrome://global/skin/icons/ inconsistently named

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Alex Vincent [:WeirdAl]]

The winstripe theme has icons under a different capitalization scheme than other
themes.

Example:  chrome://global/skin/icons/close.gif

This will render in SeaMonkey trunk builds, but not in Mozilla Firefox 1.0.6.

Using chrome://global/skin/icons/Close.gif doesn't work either across all platforms.

Please fix these to use a consistent file naming system on all platforms. 
close.gif is not the only instance.

The simplest fix is to edit
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/jar.mn
and compare against other jar.mn files.

Comment 1

[Alex Vincent [:WeirdAl]]

Err, oops.  There will need to be related changes to various theme-related CSS
files as well.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

I think this is invalid, you can't assume specific naming of files in themes
(except .css files).

Comment 3

[[e-mail]]

Right, not that it stops people from trying; I think the "new mail alert" icon
is the most obvious, but I was sure that there were other examples.

However if the name in the .css or jar.mn differs from CVS then that is a bug.

Comment 4

[Alex Vincent [:WeirdAl]]

Well, what if we did both:  rename the files in CVS and also within the
jar.mn/CSS stylesheets?

I didn't want to suggest that course of action, because of case-insensitive
operating systems.

I just want a consistent URI within global.  biesi suggests using id or class
attributes to refer to the images.  Adding extra id attributes within XBL
bindings documents is not a nice thing, though...