304021 - [PatchReader] Extend Patch Viewer functionality to Subversion

Status: RESOLVED WONTFIX

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Shailesh Kochhar]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

Bugzilla patch viewer has the ability to view patches in formatted form that is
easier to deal with and handle than raw code. Currently the patch viewer
interfaces with bonsai, cvs and lxr to extract current versions from source
control. It would be beneficial to extend this ability to include subversion and
other version control servers as well.

Reproducible: Always

Comment 1

[timeless]

we sometimes accept patches.

Comment 2

[Shailesh Kochhar]

I'm willing to work on this, but I don't have any experience with the bugzilla codebase so I'd need to work with someone on it to get going.

Comment 3

[Michael]

Bug 342075 might be related to this, at least from an implementation point of view, as it was suggested by mkanat in comment #3 to implement such functionality using the proposed XML/RPC (Bug 224577) backend for various sorts of feature delegation or interfacing. 
So, more generally this might probably be better described as "standard VCS interface"?

Comment 4

[Tiago Mello [:timello]]

Attachment: v1

Comment 5

[Tiago Mello [:timello]]

Attachment: PatchReader SVN support

I will probably going to submit it to rt.cpan.

Comment 6

[Tiago Mello [:timello]]

Attachment: v2

Comment 7

[Teemu Mannermaa (:wicked)]

Comment on attachment 588201 [details] [diff] [review]
PatchReader SVN support

Thanks for this patch! I'm adding it to the PatchReader module and it will be in the next version. If you don't mind, I'll modify the changes as needed to fit into PatchReader and hopefully add some specific tests.

>--- PatchReader-0.9.6/SVNClient.pm	1969-12-31 21:00:00.000000000 -0300
>+++ PatchReader-0.9.7/SVNClient.pm	2012-01-12 20:44:46.000000000 -0200
>@@ -0,0 +1,34 @@
>+# The contents of this file are subject to the Mozilla Public
>+# License Version 1.1 (the "License"); you may not use this file

Any chance you could license this file with Artistic license, because that's the license used for the bulk of the PatchReader. If you want MPL, then would you mind if we do MPL v2 instead because that's what Bugzilla is licensed with these days..

>+# The Initial Developer of the Original Code is Netscape Communications
>+# Corporation. Portions created by Netscape are
>+# Copyright (C) 2003 Netscape Communications Corporation. All
>+# Rights Reserved.

Seriously? Netscape contributed something for this file? :)

Comment 8

[Tiago Mello [:timello]]

(In reply to Teemu Mannermaa (:wicked) from comment #7)
> Comment on attachment 588201 [details] [diff] [review]
> PatchReader SVN support
> 
> Thanks for this patch! I'm adding it to the PatchReader module and it will
> be in the next version. If you don't mind, I'll modify the changes as needed
> to fit into PatchReader and hopefully add some specific tests.

Sure! Feel free to change it if needed!

> 
> >--- PatchReader-0.9.6/SVNClient.pm	1969-12-31 21:00:00.000000000 -0300
> >+++ PatchReader-0.9.7/SVNClient.pm	2012-01-12 20:44:46.000000000 -0200
> >@@ -0,0 +1,34 @@
> >+# The contents of this file are subject to the Mozilla Public
> >+# License Version 1.1 (the "License"); you may not use this file
> 
> Any chance you could license this file with Artistic license, because that's
> the license used for the bulk of the PatchReader. If you want MPL, then
> would you mind if we do MPL v2 instead because that's what Bugzilla is
> licensed with these days..

It can be Artistic license or MPL v2. You choose.

> 
> >+# The Initial Developer of the Original Code is Netscape Communications
> >+# Corporation. Portions created by Netscape are
> >+# Copyright (C) 2003 Netscape Communications Corporation. All
> >+# Rights Reserved.
> 
> Seriously? Netscape contributed something for this file? :)

Haha, nothing at all :)

Thanks wicked!

Comment 9

[Tiago Mello [:timello]]

Hey wicked,

Any chance to review this patch and update PatchReader with the SVN support?

Comment 10

[Frédéric Buclin]

Comment on attachment 588203 [details] [diff] [review]
v2

We removed all CVS-specific code from Bugzilla, see bug 1068494. At this point, there is no plan to add SVN, which isn't much more popular these days.