304042 - Please add separator line under "Check for updates" like in firefox

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Andreas Morawietz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050809 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050809 Firefox/1.0+

Please add a separator-line in Help-menu under "Check for updates" like in
firefox. So, "About thunderbird" is separated from "Check for updates".

So, it's easier to see "Check for updates".



Reproducible: Always

Comment 1

[Adam Guthrie]

version 1.0+ (20050808)

Works for me. This is fixed in the recent builds.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mail/base/content/mailWindowOverlay.xul&mark=1719#1719

Comment 2

[Andreas Morawietz]

I have installed newest build, but there is no seperator between "check for
updates" and "About ....".

Comment 3

[Adam Guthrie]

Confirming. This would be pretty easy to do, but I just don't know if we really
need it in Thunderbird there being so few options in that menu and all...

Comment 4

[Scott MacGregor]

Attachment: the fix

we'll do it so we are consistent with firefox even though we don't have many
items in this menu.

Comment 5

[Asaf Romano (gone)]

No reason to #ifdef it out on mac.

Comment 6

[Andreas Morawietz]

(In reply to comment #5)
> No reason to #ifdef it out on mac.

Yes, I also wondered why it has been #ifdef out on mac....

Comment 7

[Scott MacGregor]

asaf: it's if'defed out on the mac in firefox.

Comment 8

[Asaf Romano (gone)]

It's not:
http://lxr.mozilla.org/seamonkey/source/browser/base/content/baseMenuOverlay.xul#91

yeah, ben did it in a pretty confusing way...

Comment 9

[Scott MacGregor]

I'm confused because it is if'defed out on Mac OS X in Firefox:

http://lxr.mozilla.org/seamonkey/source/browser/base/content/baseMenuOverlay.xul#98

Not ifdefing' it out leaves an extra menusepartor

Comment 10

[Asaf Romano (gone)]

look at this checkin:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=baseMenuOverlay.xul&branch=&root=/cvsroot&subdir=mozilla/browser/base/content&command=DIFF_FRAMESET&rev1=1.10&rev2=1.11

On Mac, the separator is before the "Check For Updates..." menuitem

Comment 11

[Scott MacGregor]

Attachment: better fix

ok, this copies Firefox a little more closely than the last patch, thanks for
pointing that checkin out to me Asaf.