304053 - Inconsistent focus indication in Midas

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Mike Cowperthwaite]

If you click on a Midas editor (e.g at the demo page, or in the mail compose 
window) the focus indication is limited to the flashing caret (perhaps not even 
that -- bug 64451, bug 101333, I think some mail bugs about this too).

But if you tab into the editor, a focus ring is drawn around perimeter.  In the 
mail compose window, this can be seen by using Shift+Tab to the editor, or by 
setting the focus to the attachment bucket and then tabbing -- there is code to 
handle a tab from Subject which appears to bypass the normal action.  In fact, 
that code may be in place explicitly to suppress the display of the focus ring.
(Comments in the code?  We don't need no steeenking comments!)

Per Neil, "this is because ShiftFocus calls nsDocShell::SetHasFocus - but maybe 
that should be suppressed for editor."

Aaron, do you think this qualifies as an 'access' bug?

Comment 1

[[e-mail]]

Attachment: Proposed patch

Mike, sorry, I'd confused SetHasFocus with SetCanvasHasFocus.

I've only tested this with the compose window as Midas isn't working in trunk.

Comment 2

[[e-mail]]

Comment on attachment 192143 [details] [diff] [review]
Proposed patch

Low risk patch to disable the tab focus ring for editable frames.

Comment 3

[[e-mail]]

Fix checked in.

Comment 4

[Mike Cowperthwaite]

Verified fixed (tested only the message-compose window case) with TB 1.0+0819.