304081 - Improve the context menu of view page/selection source

Status: RESOLVED FIXED

(Toolkit :: View Source, defect, P3)

Description

[Asaf Romano (gone)]

The current context menu of View Page Source and View Selection Source windows
has some problems
 * There's an unnecessary "Find Again" item.
 * There's an unnecessary separator between "Copy" to "Select All" (see
browser's context menu)
 * The "Reload" command is missing.

Also, we might want to add the last two items from the View menu ("Syntax
Highlighting" and "Warp Long Lines").

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

So, I really need to do a thorough pass through the entire UI to make sure that
context menus are consistent throughout. Right now they're really not. For
instance, while Mano's right in pointing out that there's no seperator between
"Copy" and "Select All" in the context menu of the browser, that's only when
text is selected. When there's no text selected, there's no copy entry (which is
fine) but there *is* a seperator between copy and select all on the context
menus of text areas like the one I'm typing in right now. Gah.

But, specifically for this bug, Mano's on the money; although while I agree that
"Wrap long lines" would be useful in the context menu, I don't think there's a
lot of value-add to the "syntax highlighting" toggle. It's a pretty
low-percentage use, and can stay relegated to the view menu IMO.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Mano, I might take a pass at this if you think it's simple enough XUL for me to hack on. If so, just reassign to me?

Comment 3

[Shriram (irc: Mavericks)]

'Syntax Highlighting' and 'Wrap Long Lines' are added.
Rest of the three problems still apply.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Moving to the backlog (P3) since nobody is working on it now.

Honza

Comment 5

[Sebastian Zartner [:sebo]]

To me it looks that all mentioned issues are already gone.

* "Find Again" is gone
* There's no separator between "Copy" and "Select All" (There is still one in the page's context menu, as pointed out by Mike, but that's another issue, I guess.)
* There's a reload button
* The options "Syntax Highlighting" and "Wrap Long Lines" are there (as pointed out by Shriram earlier)

Therefore I finally close this issue.

Sebastian

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the update Sebastian!
Honza