304148 - Adding some information to Dependency Graph

Status: NEW

(Bugzilla :: Dependency Views, enhancement)

Description

[Dmitry Pupkov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; ru-RU; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; ru-RU; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

I think, it's a good idea for adding some additional information to
DependencyGraph, such as "Status Whiteboard" and "Target Milestone"

Reproducible: Always

Steps to Reproduce:

Comment 1

[Dmitry Pupkov]

Attachment: My patch for adding info

This is my patch for adding "Status Whiteboard" and "Target Milestones" into
Dependency Graph.

Comment 2

[Max Kanat-Alexander]

You'll probably want to pick another reviewer than justdave. Read the Reviewers
List, which is linked from the Contributor's Guide.

The Reviewers List is at: http://www.bugzilla.org/docs/reviewer-list.html

Comment 3

[Jouni Heikniemi]

Comment on attachment 192207 [details] [diff] [review]
My patch for adding info

The patch has unfortunately bitrotten, doesn't apply to the tip.

>Index: showdependencygraph.cgi
>===================================================================
>+	my $status_whiteboard = "";
>+	my $target_milestone = "";
>     my $stat;

You have tabs here (and in a few other positions; check for them before the
next iteration). Also use runtests.pl to run the testing suite prior to
patching; it'll find these as well as several other issues.

>+	if (!$cgi->param('showSW')) {
>+		$status_whiteboard = '';
>+	}

"SW" and "TM" are not common terminology in Bugzilla circles; please use
"showWhiteboard" and "showMilestone" instead.

>+		$status_whiteboard = "\\n".$status_whiteboard;

Hint: '\n' is a bit cleaner way to produce a literal \n than "\\n".


>+	  <td colspan="3">
>+		<input type="checkbox" name="showSW"
>+          [% " checked" IF showSW %]>
>+		Show <B>"Status Whiteboard"</b> on dependency graph
>+ 	  </td>

Please use the <label> tag for the checkbox labels to increase clickable area.