304166 - Attachment drag issues in Message Compose window

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect)

Description

[Mike Cowperthwaite]

TB has a moderately slick feature where an attachment (file or URL) dragged over 
the envelope will pop open the attachment bucket (hereafter, "attbkt") if it's 
not already shown.  This has a couple of few problems:

1) If the attachment is not actually dropped (drag cancelled or dropped 
elsewhere), the attbkt is not closed.  (Having an empty attbkt is not 
necessarily a terrible thing, but see bug 230904.)


2) If the dragged object is a mailto: URL, the attbkt is opened, despite the 
fact that if dropped, a mail address is added to the address list (in a broken 
form, but that's another bug).  The user presumably knows that it's an address 
being dragged, so the sudden appearance of the attbkt is confusing.


3a) If the dragged object is a mailto: URL, the attbkt (which may be validly 
open due an existing attachment) allows the drop, but passes it to to the 
address widget; it should show the No Drop icon.

3b) If the dragged object is an attachment, the address fields allow the drop; 
once the attbkt is open, the address fields should show the No Drop icon.

Items 3a & 3b are because it's a little confusing to drop an item in one 
location and have it appear in a different location.


4) The Attach toolbar button is also being used as a drop target.  This is 
pretty nonstandard and I don't think it's useful.

Comment 1

[Mike Cowperthwaite]

The obvious solution to item 1 would be to add this code in 
MsgComposeCommands.js:
  onDragExit: function (aEvent, aDragSession)
    {
+     if (!MessageHasAttachments())
+     {
+       ChangeAttachmentBucketVisibility(true);
+     }
    },

However, this causes UI flickering due to too many dragEnter/dragExit events 
being sent as the cursor moves across the field.

Comment 2

[Mike Cowperthwaite]

See also bug 291388, bug 291389.

Comment 3

[Wayne Mery (:wsmwk)]

resolved?

Comment 4

[Alessandro Castellani [:aleca]]

Indeed, fixed with the work done on bug 1640760.