304233 - preference has no properties chrome://global/content/bindings/preferences.xml (line 1021)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Ronny Perinke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8b4) Gecko/20050810 Firefox/1.0+ (Sephiroth/AXP)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8b4) Gecko/20050810 Firefox/1.0+ (Sephiroth/AXP)

In Firefox 1.0+ builds:

closing the new advanced javascript settings (since 20050810) causes the
following error to occur in js console:
Error: preference has no properties
Source: chrome://global/content/bindings/preferences.xml
Line: 1021

Reproducible: Always

Steps to Reproduce:
1. open the js console
2. open to the content prefs
3. open the advanced js options (for build with bug <a
href="https://bugzilla.mozilla.org/show_bug.cgi?id=299424">#299424</a> fixed)
4. close advanced js options window and have a look at the js console

Actual Results:  
Error: preference has no properties
Source: chrome://global/content/bindings/preferences.xml
Line: 1021

Expected Results:  
no error

Comment 1

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050810
Firefox/1.0+ ID:2005081006

Confirmed

Comment 2

[Ronny Perinke]

Attachment: fixex tow problems 1.) initial problem (preference has no properties) and 2.) advanced js button stil active when js disabled

I noticed another problem: the button for the advanced js settings should be
disabled when javascript is disabled. (a regression from bug #299424
https://bugzilla.mozilla.org/show_bug.cgi?id=299424)

the patch fixes both bugs, the initial one and this one.

console errors for both where:
TypeError: button has no properties
*** No preference found for pref.advanced.javascript.disable_button.advanced

1st caused by
http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/content.xul#124

2nd caused by
http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/content.xul#131

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 192319 [details] [diff] [review]
fixex tow problems 1.) initial problem (preference has no properties) and 2.) advanced js button stil active when js disabled

We need to add this new pref to the <preferences> element, not remove it, since
that lets sysadmins lock down the panel.

Comment 4

[Ronny Perinke]

Attachment: updated patch

- added the new pref to the <preferences> element instead of removing it (sry,
didn't noticed that)

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 192323 [details] [diff] [review]
updated patch

You need to ask for review from someone specifically, otherwise it won't be
noticed.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 192323 [details] [diff] [review]
updated patch

r+a=me, minus the tabs in the first section of the patch.  Good catch, btw.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Checked in trunk and branch, thanks for the patch Ronny!

Trunk:
Checking in content.xul;
/cvsroot/mozilla/browser/components/preferences/content.xul,v  <--  content.xul
new revision: 1.12; previous revision: 1.11
done

1.8 Branch:
Checking in content.xul;
/cvsroot/mozilla/browser/components/preferences/content.xul,v  <--  content.xul
new revision: 1.11.2.1; previous revision: 1.11
done