304237 - Enable xpcom under windows debuggers to filter assertions the way it does without a debugger

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[timeless]

to enable this feature,
set XPCOM_DEBUG_DLG=1, or if you're already in the debugger, just poke the 
static to 2.

Comment 1

[timeless]

Attachment: let debugger users benefit from windbgdlg if they want to

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 192308 [details] [diff] [review]
let debugger users benefit from windbgdlg if they want to

why 2?

Comment 3

[timeless]

0 is used by the variable to mean it hasn't checked the env var, 1 means that 
the user had the env var unset or set to 0, 2 means the user set the env var to 
1. i'm just abusing the fact that static means things start at 0.

Comment 4

[timeless]

Comment on attachment 192308 [details] [diff] [review]
let debugger users benefit from windbgdlg if they want to

this is localized windows code that is only used by debug code and only affects
users who are in debuggers. the benefit is that users in debuggers can choose
to ignore certain assertions. for its audience this is a good reward. for
everyone else this is basically no risk.

Comment 5

[timeless]

Comment on attachment 192308 [details] [diff] [review]
let debugger users benefit from windbgdlg if they want to

mozilla/xpcom/base/nsDebugImpl.cpp	3.11