304268 - edit users form should have an item for "edit this user"

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[timeless]

currently if i have an email address that i want to promote (which i usually 
get fully qualified from bugzilla either http or smtp), i have to either use a 
keyword (which i rarely do), or load edit users, search for a substring match 
on the whole string, and then click on the exact match (since it's the only 
match).

the drop down has substring, regexp, not regexp and something else. it doesn't 
have "just take me to this user". that's the option i'd like to see added

Comment 1

[GavinS]

or just go straight to the user if only 1 user matches any of the search types?

Comment 2

[timeless]

no.
    
Edit user ... Real name 
[e-mail] Richard Suitor 
[e-mail] T Rowley (IBM) 

i wanted to edit [e-mail], not get a list that didn't forward to [e-mail]

Comment 3

[GavinS]

Attachment: V1: add a 'find this user' option

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 192994 [details] [diff] [review]
V1: add a 'find this user' option

The edit.html.tmpl template should not show the "back to the user list" link in
the footer if you've used matchtype="exact" because it takes you to no user
list, but to the page you're currently viewing. (Turning [% IF
listselectionvalues %] into
[% IF listselectionvalues.matchtype == 'exact' %] should do the trick.)

Good otherwise.

>+                $query .= " = ? ";

Nit: surrounding blanks aren't necessary here.

Comment 5

[Marc Schumann [:Wurblzap]]

s/==/!=/

Comment 6

[GavinS]

Attachment: V2: add a 'find this user' option

Comment 7

[Marc Schumann [:Wurblzap]]

Comment on attachment 194087 [details] [diff] [review]
V2: add a 'find this user' option

Your patch has been broken by bug 305976.

>Index: editusers.cgi
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v
>retrieving revision 1.100
>diff -u -r1.100 editusers.cgi
>--- editusers.cgi	26 Aug 2005 10:28:07 -0000	1.100
>+++ editusers.cgi	28 Aug 2005 12:48:10 -0000
>@@ -116,6 +116,9 @@
>             } elsif ($matchtype eq 'notregexp') {
>                 $query .= $dbh->sql_not_regexp . ' ?';
>                 $matchstr = '.' unless $matchstr;
>+            } elsif ($matchtype eq 'exact') {
>+                $query .= '= ?';

this needs to be

   $query .= "$expr = ?";

now.

Comment 8

[GavinS]

Attachment: add a 'find this user' option, v3

Comment 9

[Frédéric Buclin]

Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.102; previous revision: 1.101
done
Checking in template/en/default/admin/users/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/users/search.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/search.html.tmpl,v
 <--  search.html.tmpl
new revision: 1.2; previous revision: 1.1
done

Comment 10

[timeless]

as a major consumer of bmo, i'd like to request this make the next bmo upgrade :)

otherwise it'll take me 18months to verify this bug :(

Comment 11

[Dave Miller [:justdave]]

(In reply to comment #10)
> as a major consumer of bmo, i'd like to request this make the next bmo upgrade :)

Ask me nicely and maybe I'll apply it locally on b.m.o, but this won't make 2.20.