304269 - nsExtensionManager.js.in: attempt to remove non-existent file

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[shutdown]

http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#3403
3400       var autoregFile = getFile(KEY_PROFILEDIR, [FILE_AUTOREG]);
3401       if (val)
3402         autoregFile.create(nsILocalFile.NORMAL_FILE_TYPE, PERMS_FILE);
3403       else if (!autoregFile.exists())
3404         autoregFile.remove(false);

Line 3403 is supposed to be "else if (autoregFile.exists())", isn't it?

Comment 1

[Robert Strong (they/them - no direct email)]

Yes it is as noted in bug 304115. The more important question is whether this
change will adversely affect other code that has been working properly since
that was changed several months ago.
http://webtools.mozilla.org/bonsai/cvsblame.cgi?file=mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in&rev=&root=/cvsroot#3401

I would prefer to just remove the else if for now since nsAppRunner removes the
file and it is very possible that if the EM code were to remove it a
re-registration would not occur on restart. I believe the following is true
though I haven't investigated it yet:
Install extension (requires restart) -> .autoreg is created.
Install theme (does not require restart) -> .autoreg is removed.
Restart and re-registration does not occur.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: safe patch

Benjamin - this is about as safe a change as can be... I think it is
appropriate for 1.8b4

Comment 3

[Robert Strong (they/them - no direct email)]

Fixed for 1.8b4