304335 - Status and resolution empty in whine mails

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect)

Description

[Marc Schumann [:Wurblzap]]

Whine mails from whine.pl have got empty status and resolution fields. This is a
regression of bug 215148.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Frédéric Buclin]

Comment on attachment 192393 [details] [diff] [review]
Patch

tested, works. r=LpSolit

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Note that field-descs.none.tmpl itself processes variables.none.tmpl, so the
redundant calls in the templates being modified by this patch should be removed.

Comment 4

[Marc Schumann [:Wurblzap]]

Can this be done on check-in, or should I upload a fresh patch?

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> Can this be done on check-in, or should I upload a fresh patch?

Several templates mention both variables.none.tmpl and field-descs.none.tmpl.
The best thing to do IMO is to open a new bug and do this cleanup there. I will
check in this patch as is and let fix this nit in a separate bug.

Comment 6

[Frédéric Buclin]

tip:

Checking in template/en/default/whine/mail.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/mail.html.tmpl,v 
<--  mail.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/whine/mail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/mail.txt.tmpl,v 
<--  mail.txt.tmpl
new revision: 1.3; previous revision: 1.2
done


2.20rc2:

Checking in template/en/default/whine/mail.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/mail.html.tmpl,v 
<--  mail.html.tmpl
new revision: 1.2.4.1; previous revision: 1.2
done
Checking in template/en/default/whine/mail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/mail.txt.tmpl,v 
<--  mail.txt.tmpl
new revision: 1.2.4.1; previous revision: 1.2
done