Closed Bug 304338 Opened 19 years ago Closed 19 years ago

nsWindowSH doesn't allow xpcom components to replace its properties

Categories

(Core :: DOM: Core & HTML, enhancement)

x86
Windows XP
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

The code tries and fails to set security flags so that things work, 
unfortunately the code isn't reentrant safe and reenters, resulting in 
clobbered values.
Attachment #192398 - Flags: superreview?(jst)
Attachment #192398 - Flags: review?(jst)
Comment on attachment 192398 [details] [diff] [review]
make the code reentrancy safe

r+sr=jst
Attachment #192398 - Flags: superreview?(jst)
Attachment #192398 - Flags: superreview+
Attachment #192398 - Flags: review?(jst)
Attachment #192398 - Flags: review+
Status: NEW → ASSIGNED
Comment on attachment 192398 [details] [diff] [review]
make the code reentrancy safe

mozilla/dom/src/base/nsDOMClassInfo.cpp 	1.295

this change is safe, small, tested, has been on trunk for a while, and we need
it for the branch
Attachment #192398 - Flags: approval1.8b4?
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 192398 [details] [diff] [review]
make the code reentrancy safe

-'d approval1.8b4 request.  to get onto the branch at this point bugs needs to
be nominated for 1.8b4.  also, it's unclear in this bug what this will actually
fix and why we would need this.
Attachment #192398 - Flags: approval1.8b4? → approval1.8b4-
Comment on attachment 192398 [details] [diff] [review]
make the code reentrancy safe

Timeless, request that the bug be marked blocking1.8b4 first, get drivers to
agree (I'll agree, but at this point I will want a second).

This is a safe fix that I'm sure at least one company building on the platform
wants; its bug ought to be considered for 1.8, even at this point.  Don't let
the "enhancement" status fool you, fellow drivers.

/be
See comment 5.

/be
sorry, i'm 4000 bugmails behind, i just got to this one. my company needs this
change, it's blocking our product which is being built on 1.8.
Flags: blocking1.8b4?
Comment on attachment 192398 [details] [diff] [review]
make the code reentrancy safe

Urging reconsideration, for b4 or b5 -- this is a safe fix that makes JS API
usage work the way it should.

/be
Attachment #192398 - Flags: approval1.8b4- → approval1.8b4?
Attachment #192398 - Flags: approval1.8b4? → approval1.8b4+
Time is short for 1.8b4. If this isn't landed today, it's not going to make the
train.
mozilla/dom/src/base/nsDOMClassInfo.cpp 	1.292.2.8
Flags: blocking1.8b4?
Keywords: fixed1.8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: