Percent complete isn't checkmarked in the task-list context menu

RESOLVED FIXED

Status

Calendar
Sunbird Only
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Joey Minta, Assigned: Joey Minta)

Tracking

({polish})

Details

Attachments

(1 attachment)

1.57 KB, patch
Michiel van Leeuwen (email: mvl+moz@)
: first-review+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
In Sunbird 0.2, the task-list context menu displayed a checkmark next to the
appropriate percent-complete label.  This doesn't happen anymore.
(Assignee)

Comment 1

13 years ago
Created attachment 192408 [details] [diff] [review]
use percentComplete

This section of the code hadn't been updated to use .percentComplete
Assignee: mostafah → jminta
Status: NEW → ASSIGNED
Attachment #192408 - Flags: first-review?(mvl)
Comment on attachment 192408 [details] [diff] [review]
use percentComplete

> 
>-      if( document.getElementById( "percent-"+toDoItem.percent+"-menuitem" ) )
>+      if( document.getElementById( "percent-"+toDoItem.percentComplete+"-menuitem" ) )
>       {
>-         document.getElementById( "percent-"+toDoItem.percent+"-menuitem" ).setAttribute( "checked", "true" );
>+         document.getElementById( "percent-"+toDoItem.percentComplete+
>+                       "-menuitem" ).setAttribute( "checked", "true" );

Nit: move the string generation on one line, like:
	 document.getElementById("percent-" + toDoItem.percentComplete +
"-menuitem").
		  setAttribute("checked", "true");
(also has some whitespace changes)

r=mvl with that.
Attachment #192408 - Flags: first-review?(mvl) → first-review+
(Assignee)

Comment 3

12 years ago
Patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.