304374 - |nsCOMPtr<nsIInterfaceInfoManager> iim = XPTI_GetInterfaceInfoManager()| leaks

Status: RESOLVED FIXED

(Core Graveyard :: XTF, defect)

Description

[Peter Van der Beken [:peterv]]

There's a couple of places in the tree where we do:

nsCOMPtr<nsIInterfaceInfoManager> iim = XPTI_GetInterfaceInfoManager();

which leaks because XPTI_GetInterfaceInfoManager addrefs its return value.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

This fixes those leaks in content/xtf and in extensions/java.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 192437 [details] [diff] [review]
v1

r+sr=jst

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This looks like it's just a leaked refcount of a singleton.

Comment 4

[Daniel Veditz [:dveditz]]

If this is a problem lxr shows other calls, in mozilla/extensions/python and mozilla/java/xpcom (why is there both extensions/java/xpcom and java/xpcom?). Correct me if I'm wrong, but there's only ever one xptiInterfaceInfoManager right?

Comment 5

[Peter Van der Beken [:peterv]]

Yes, this is a singleton and this function has been removed on the trunk.