304400 - chrome.manifest parser inconsistent

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Ed Hume]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050811 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050811 Firefox/1.0+

When handling jarfiles, the chrome.manifest parser will not handle more than one
tab or more than one space between entries on each line. So, for example,

skin	help	SphereGnome	jar:chrome/spheregnome-fx.jar!/help/
works, where
skin	help		SphereGnome	jar:chrome/spheregnome-fx.jar!/help/
does not.

OTOH, 
skin	help			SphereGnome		chrome/help/
works fine.

If the parser worked consistently, it would be easier to read/debug
chrome.manifest files.



Reproducible: Always

Comment 1

[Dave Townsend [:mossop]]

Don't totally understand this bug. Why would hte thrid line work when the first
two don't?

As it is, My extensions have any number of tabs and spaces in them from 1 up to
4 and I have found no problems here.

Comment 2

[Ed Hume]

Sorry for not writing more clearly.

If I take a perfectly well-functioning chrome.manifest file which references jar
files and add sufficient tabs to line up the elements of each line, the theme
fails to load.

An example: 

skin	global	ColorGnome	jar:chrome/colorgnome-fx.jar!/global/
skin	mozapps	ColorGnome	jar:chrome/colorgnome-fx.jar!/mozapps/
skin	browser	ColorGnome	jar:chrome/colorgnome-fx.jar!/browser/
skin	communicator	ColorGnome	jar:chrome/colorgnome-fx.jar!/communicator/
skin	tbx	ColorGnome	jar:chrome/colorgnome-fx.jar!/tbx/
skin	help	ColorGnome	jar:chrome/colorgnome-fx.jar!/help/

worked, but

skin	global		ColorGnome	jar:chrome/colorgnome-fx.jar!/global/
skin	mozapps		ColorGnome	jar:chrome/colorgnome-fx.jar!/mozapps/
skin	browser		ColorGnome	jar:chrome/colorgnome-fx.jar!/browser/
skin	communicator	ColorGnome	jar:chrome/colorgnome-fx.jar!/communicator/
skin	tbx		ColorGnome	jar:chrome/colorgnome-fx.jar!/tbx/
skin	help		ColorGnome	jar:chrome/colorgnome-fx.jar!/help/

did not work. I have taken themes that work, made changes to the
chrome.manifest,  observed themes failure, then restored the original
chrome.manifest and had theme success.

OTOH, doing something similar when the file was referencing folders directly
cuased no problems. Thus

skin	global		SphereGnome		chrome/global/
skin	mozapps		SphereGnome		chrome/mozapps/
skin	browser		SphereGnome		chrome/browser/
skin	help		SphereGnome		chrome/help/
skin	communicator	SphereGnome		chrome/communicator/
skin	tbx		SphereGnome		chrome/tbx/

produces a theme that loads with no problem.

The parser handles chrome.manifest differently, depending on whether is is
dealing with a jar file or just directories.

Comment 3

[Dave Townsend [:mossop]]

The following works just fine for me (hopefully this displays ok):

content			nightly																				jar:chrome/nightly.jar!/content/
skin				nightly					classic/1.0										jar:chrome/nightly.jar!/skin/
locale			nightly					en-US													jar:chrome/nightly.jar!/locale/en-US/

overlay			chrome://browser/content/browser.xul				
chrome://nightly/content/browserOverlay.xul
overlay 		chrome://messenger/content/messenger.xul 		
chrome://nightly/content/messengerOverlay.xul

style 			chrome://browser/content/browser.xul 					chrome://nightly/skin/browser.css
style 			chrome://messenger/content/messenger.xul 		
chrome://nightly/skin/browser.css
style 			chrome://global/content/customizeToolbar.xul 
chrome://nightly/skin/browser.css

Comment 4

[Dave Townsend [:mossop]]

Attachment: Working manifest with varying numbers of tabs

Bugzilla trashed that so attaching the example seems a much better idea. The
content, locale and skin lines all reference a jar file and use varying amounts
of tabs to line them up and this causes no trouble.

Comment 5

[Ed Hume]

For whatever reason, I am no longer having this problem.

So: WFM and we can put it to bed as invalid.mm