304405 - Document Bookmarks > Bookmark All Tabs

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Jeff Walden (gone starting June 8)]

See bug 300412 and attachment 192265 [details] [diff] [review].

Comment 1

[Jeff Walden (gone starting June 8)]

*** Bug 305218 has been marked as a duplicate of this bug. ***

Comment 2

[Jeff Walden (gone starting June 8)]

Note that the "book all tabs" checkbox in the Add Bookmark dialog is gone, so
that has to be fixed too.

Comment 3

[Gids Goldberg]

Attachment: Documents 'Bookmark All Tabs' in Tabbed Browsing and Menu Reference

Feedback on the wording would be appreciated.

Comment 4

[Jeff Walden (gone starting June 8)]

Comment on attachment 194526 [details] [diff] [review]
Documents 'Bookmark All Tabs' in Tabbed Browsing and Menu Reference 

>Index: browser/locales/en-US/chrome/help/tabbed_browsing.xhtml

>+        tabs in the current window to a new bookmarks folder.</li>

On the really nitpicky side, we seem to use "bookmark folder" more than
"bookmarks folder".

>Index: browser/locales/en-US/chrome/help/menu_reference.xhtml

>   <p>Adds the current page to your bookmarks. A dialog will be displayed,
>     allowing you to choose a title for the bookmark and specify where you
>     want it to be stored.</p>
>+  
>+  <h3 id="bookmark_all_tabs">Bookmark All Tabs...</h3>
>+  <p>Adds all the tabs in the current window to a new bookmarks folder. A dialog
>+  will be displayed, allowing you to choose the name of the folder and specify
>+  where it will be stored.</p>

See previous comment on "bookmarks folder".  Also, we should mirror the wording
in the previous section and use "...where you want it to be stored".

Pending approval, I'll fix these nits on checkin.

Comment 5

[Jeff Walden (gone starting June 8)]

One other thing that I'll fix is indentation -- see the rest of
menu_reference.xhtml to see the indentation style we use.

Comment 6

[Jeff Walden (gone starting June 8)]

Patch checked in on branch and trunk.

Comment 7

[Marek Stępień [:marcoos, inactive]]

+      <li>Press &accelKey;+&shiftKey;+<kbd>D</kbd> or select

This needs to be something like:

<li><span class="noUnix">Press &accelKey;+&shiftKey;+<kbd>D</kbd> or
select</span><span class="unix">Select</span>

as the shortcut is Mac- and Windows-only.

Comment 8

[Steffen Wilberg]

Indeed, see bug 305955. Reopening.

Comment 9

[Marek Stępień [:marcoos, inactive]]

Attachment: Make the 'press ... or select' Windows- and Mac-only.

Patch fixing this issue.

Comment 10

[Steffen Wilberg]

Comment on attachment 194766 [details] [diff] [review]
Make the 'press ... or select' Windows- and Mac-only.

r=me.

Comment 11

[Jeff Walden (gone starting June 8)]

Ouch, it's been a while since I missed something obvious like that; at least
we're not going to have any real problems because of this, as the patch is
already approved and ready for checkin.

Comment 12

[Steffen Wilberg]

Attachment: what I checked in

Well, and I was a bit quick to r+ that patch, which didn't apply because it
didn't contain the previous change, and didn't mention &shiftKey;.

Comment 13

[Steffen Wilberg]

Fixed. Yay, first checkin from my new system!