Rename "Sanitize" feature in docs

RESOLVED FIXED in Firefox1.5

Status

RESOLVED FIXED
13 years ago
2 years ago

People

(Reporter: jwalden+fxhelp, Assigned: steffen.wilberg)

Tracking

({fixed1.8, late-l10n})

Trunk
Firefox1.5
fixed1.8, late-l10n

Details

Attachments

(1 attachment, 1 obsolete attachment)

9.66 KB, patch
steffen.wilberg
: review+
Details | Diff | Splinter Review
(Assignee)

Comment 1

13 years ago
Created attachment 192691 [details] [diff] [review]
patch

Only renames the item. This patch doesn't attempt to fix bug 302607.
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #192691 - Flags: review?(jwalden+fxhelp)
(Reporter)

Comment 2

13 years ago
Comment on attachment 192691 [details] [diff] [review]
patch

>Index: mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml

>+  <p>Clears the items which are selected in the Clear Private Data Settings

The dialog's just "Clear Private Data".

>Index: mozilla/browser/locales/en-US/chrome/help/prefs.xhtml

>-  <h3 id="sanitize">Sanitize Settings</h3>
>+  <h3 id="sanitize">Clear Private Data Settings</h3>

Let's rev the id here to better reflect reality -- "clear_private_data" should
do fine.

>+    &brandShortName;. &pref.pluralCaps; for this are in the <em>Clear Private
>+    Data...</em> dialog.</p>

There's no ellipsis in the dialog's name.

>Index: mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf

You've got a bunch of unrelated changes in here from a bug whose patch I
reviewed recently; just be careful you don't check in too much if this gets
approved prior to approval of the patch in whichever bug it is.

>-        <rdf:li> <rdf:Description ID="menu-tools-sanitize" nc:name="Sanitize &brandShortName;..." nc:link="menu_reference.xhtml#sanitize"/> </rdf:li>
>+        <rdf:li> <rdf:Description ID="menu-tools-sanitize" nc:name="Clear Private Data..." nc:link="menu_reference.xhtml#sanitize"/> </rdf:li>

If this isn't linked from the options dialog, let's update the ID here.  (It
seems only prefs-sanitize is linked, so this looks like it should probably be
safe.)	If it is, file a bug to change it and other such instances on trunk to
something meaningful.  (Note that said bug may overlap with any cleanup Mike
Beltzner might do as followup to bug 285064, so it's probably best to leave it
alone at least until that's finalized.)  We'll deal with it when we've wrapped
up the remaining bugs that we determine are needed for 1.5 (bugs with a Target
Milestone of Firefox1.1).  I'd like to keep trunk and branch synced until we've
wrapped up those bugs, and then it's open season again. :-)
Attachment #192691 - Flags: review?(jwalden+fxhelp)
Attachment #192691 - Flags: review+
Attachment #192691 - Flags: approval1.8b4?
(Assignee)

Comment 3

13 years ago
Created attachment 192725 [details] [diff] [review]
fix comments

I didn't change "prefs-sanitize" since that's linked from
http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/sanitize.xul#55.
Attachment #192691 - Attachment is obsolete: true
Attachment #192725 - Flags: review+
Attachment #192725 - Flags: approval1.8b4?
(Assignee)

Updated

13 years ago
Attachment #192691 - Flags: approval1.8b4?
(Assignee)

Updated

13 years ago
Target Milestone: --- → Firefox1.1

Updated

13 years ago
Attachment #192725 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Comment 4

13 years ago
Jeff, can you check this in for me, please? My linux system died, and I can't
install a new one because my harddisk is dying, SMART status bad :(
Bug 304333 and bug 298484 as well, please.
Whiteboard: [checkin needed]
(Reporter)

Comment 5

13 years ago
(In reply to comment #4)
> Jeff, can you check this in for me, please?

Gotcha, although it may not get done until Sunday (tomorrow's the other
possibility).
(Reporter)

Comment 6

13 years ago
Patch checked in on branch and trunk; I opened bug 305228 to change the name of
the help topic that's referenced in prefs UI.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

13 years ago
Keywords: fixed1.8, late-l10n
Whiteboard: [checkin needed]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.