Closed Bug 304418 Opened 17 years ago Closed 17 years ago

"Save link as" and "Bookmark This Link" broken after bug #284868 checkin

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.8final

People

(Reporter: leaf.of.grass, Assigned: Gavin)

References

()

Details

(Keywords: fixed1.8, regression)

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+

Right-click "Save Link As" is broken

Reproducible: Always

Steps to Reproduce:
Testcase:
http://tmp.gary.elixant.com/
1. right-click tabmix+ beta .xpi and try to "save link as"
2. throws java script console error:

Error: uncaught exception: [Exception... "Component returned failure code:
0x804b000a [nsIIOService.newURI]" nsresult: "0x804b000a (<unknown>)" location:
"JS frame :: chrome://global/content/contentAreaUtils.js :: makeURI :: line 695"
data: no]

happens in current profile as well as new profile with no extensions.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812
Firefox/1.0+ ID:2005081201

Actual Results:  
causes java script error

Expected Results:  
should popup file download dialog

Suspected regression from  #284868 [Firefox]-HTTP Referer not sent at all when
"saving link as..." checkin
Status: UNCONFIRMED → NEW
Component: General → Download Manager
Ever confirmed: true
QA Contact: general → download.manager
cc Jesse for bug 284868 related
Flags: blocking1.8b4?
Version: unspecified → Trunk
Attached patch patch (obsolete) — Splinter Review
Attachment #192546 - Flags: review?(mconnor)
I will be traveling today, so it would be great if someone could check in this
patch for me on trunk and the 1.8 branch when the tree opens (assuming the patch
is reviewed and approved for the branch).
Workaround: Alt+click the link.
"Bookmark This Link..." is also broken.
Assignee: nobody → gavin.sharp
OS: Windows XP → All
Hardware: PC → All
Summary: "Save link as" broken after bug #284868 checkin → "Save link as" and "Bookmark Link" broken after bug #284868 checkin
Attached patch patch for bothSplinter Review
Fix both.
Attachment #192546 - Attachment is obsolete: true
Attachment #192606 - Flags: review?(mconnor)
Attachment #192546 - Flags: review?(mconnor)
Status: NEW → ASSIGNED
Summary: "Save link as" and "Bookmark Link" broken after bug #284868 checkin → "Save link as" and "Bookmark This Link" broken after bug #284868 checkin
Target Milestone: --- → Firefox1.1
Attachment #192606 - Flags: review?(mconnor)
Attachment #192606 - Flags: review+
Attachment #192606 - Flags: approval1.8b4+
Checked in branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: blocking1.8b4?
Blocks: 303181
No longer blocks: 284868
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.