304418 - "Save link as" and "Bookmark This Link" broken after bug #284868 checkin

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Zulith]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+

Right-click "Save Link As" is broken

Reproducible: Always

Steps to Reproduce:
Testcase:
http://tmp.gary.elixant.com/
1. right-click tabmix+ beta .xpi and try to "save link as"
2. throws java script console error:

Error: uncaught exception: [Exception... "Component returned failure code:
0x804b000a [nsIIOService.newURI]" nsresult: "0x804b000a (<unknown>)" location:
"JS frame :: chrome://global/content/contentAreaUtils.js :: makeURI :: line 695"
data: no]

happens in current profile as well as new profile with no extensions.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812
Firefox/1.0+ ID:2005081201

Actual Results:  
causes java script error

Expected Results:  
should popup file download dialog

Suspected regression from  #284868 [Firefox]-HTTP Referer not sent at all when
"saving link as..." checkin

Comment 1

[Steve England [:stevee]]

cc Jesse for bug 284868 related

Comment 2

[Jesse Ruderman]

Attachment: patch

Comment 3

[Jesse Ruderman]

I will be traveling today, so it would be great if someone could check in this
patch for me on trunk and the 1.8 branch when the tree opens (assuming the patch
is reviewed and approved for the branch).

Comment 4

[Jesse Ruderman]

Workaround: Alt+click the link.

Comment 5

[Ben Basson]

"Bookmark This Link..." is also broken.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch for both

Fix both.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Checked in branch and trunk.