"Save link as" and "Bookmark This Link" broken after bug #284868 checkin

RESOLVED FIXED in mozilla1.8final

Status

()

Toolkit
Downloads API
--
major
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Bryan Reynolds, Assigned: Gavin)

Tracking

({fixed1.8, regression})

Trunk
mozilla1.8final
fixed1.8, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+

Right-click "Save Link As" is broken

Reproducible: Always

Steps to Reproduce:
Testcase:
http://tmp.gary.elixant.com/
1. right-click tabmix+ beta .xpi and try to "save link as"
2. throws java script console error:

Error: uncaught exception: [Exception... "Component returned failure code:
0x804b000a [nsIIOService.newURI]" nsresult: "0x804b000a (<unknown>)" location:
"JS frame :: chrome://global/content/contentAreaUtils.js :: makeURI :: line 695"
data: no]

happens in current profile as well as new profile with no extensions.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812
Firefox/1.0+ ID:2005081201

Actual Results:  
causes java script error

Expected Results:  
should popup file download dialog

Suspected regression from  #284868 [Firefox]-HTTP Referer not sent at all when
"saving link as..." checkin

Updated

13 years ago
Blocks: 284868

Updated

13 years ago
Status: UNCONFIRMED → NEW
Component: General → Download Manager
Ever confirmed: true
QA Contact: general → download.manager
cc Jesse for bug 284868 related
Keywords: regression
Flags: blocking1.8b4?

Updated

13 years ago
Version: unspecified → Trunk

Comment 2

13 years ago
Created attachment 192546 [details] [diff] [review]
patch

Updated

13 years ago
Attachment #192546 - Flags: review?(mconnor)

Comment 3

13 years ago
I will be traveling today, so it would be great if someone could check in this
patch for me on trunk and the 1.8 branch when the tree opens (assuming the patch
is reviewed and approved for the branch).

Comment 4

13 years ago
Workaround: Alt+click the link.

Comment 5

13 years ago
"Bookmark This Link..." is also broken.
Assignee: nobody → gavin.sharp
OS: Windows XP → All
Hardware: PC → All
Summary: "Save link as" broken after bug #284868 checkin → "Save link as" and "Bookmark Link" broken after bug #284868 checkin
Created attachment 192606 [details] [diff] [review]
patch for both

Fix both.
Attachment #192546 - Attachment is obsolete: true
Attachment #192606 - Flags: review?(mconnor)
Attachment #192546 - Flags: review?(mconnor)
Status: NEW → ASSIGNED
Summary: "Save link as" and "Bookmark Link" broken after bug #284868 checkin → "Save link as" and "Bookmark This Link" broken after bug #284868 checkin
Target Milestone: --- → Firefox1.1

Updated

13 years ago
Attachment #192606 - Flags: review?(mconnor)
Attachment #192606 - Flags: review+
Attachment #192606 - Flags: approval1.8b4+
Checked in branch and trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Keywords: fixed1.8
Flags: blocking1.8b4?

Updated

12 years ago
Blocks: 303181
No longer blocks: 284868
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.