304434 - Left-clicked downloadable files do not have their links marked as visited until a page reload

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Bradley Chapman (not reading bugmail, still gone but not forever)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050811 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050811 Firefox/1.0+

Bug 78510's fix does not take into account any left-clicked links which cause
the browser to begin a file download. Left-clicking these links does not mark
them as visited until after the page is reloaded.

Reproducible: Always

Steps to Reproduce:
1. Go to the Web site in the URL field.
2. Left-click a file that will cause a download to start.
3. Start the download.
4. Return to the Web site and find the link that was clicked.
Actual Results:  
The link is still unvisited (a:link) instead of visited (a:visited).

Expected Results:  
The link should have changed to a:visited after the download dialog had appeared
and/or the download had been started in the DM.

Comment 1

[Bradley Chapman (not reading bugmail, still gone but not forever)]

CCing roc, as he wrote the original fix for this.

Adding dependency on 78510 (if unneeded, please remove).

Comment 2

[Harald Langhammer]

not only a linux problem

can confirm here with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050812 Firefox/1.0+ ID:2005081201

same behaviour, not marked visited until reload

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

downloads call the add-to-history code themselves, in
nsExternalHelperAppService.cpp, so they don't reach the notifyObservers code in
docshell

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Simple fix

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is a regression since I took out the Firefox hack that used to make this
"kinda" work.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, wouldn't it be better if the AddURI / AddPage implementation did this?
 After all, the current way leaves inconsistencies on reload, since AddURI
refuses to add certain schemes to history.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Then we'd have to add it to all history implementations (including those outside
our tree).

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think this will cause inconsistencies because style reresolution will
just find that the link is still not visited and do the right thing.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 192898 [details] [diff] [review]
fix

resubmitting patch

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 192898 [details] [diff] [review]
fix

fixes a regression from bug 78510

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in on branch.

Comment 13

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050827 Firefox/1.0+
ID:2005082705

Verified - but not totally fixed. Right-clicking a link and selecting Save Link
As  does not trigger the fix in this bug, and additionally does not allow such a
link to be marked visited at all, even after a page reload.

Should a new bug be filed on this issue?

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #13)
> Should a new bug be filed on this issue?

That never marked the link as visited. There already is a bug on that.