304436 - [mac] RSS button is displayed empty.

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+

I will add a screenshot to display the problem.

I build myself fx using last available sources. More infos in details

Reproducible: Always

Steps to Reproduce:
1.build fx or grab it
2.launch it
3.look at
uhttps://bugzilla.mozilla.org/enter_bug.cgi?format=guided&product=Firefoxrl bar

Actual Results:  
button in the right side, near the little arrow.

Expected Results:  
no button in it.

I am using last available cvs sources (before branching happened).

Compiled my fx using gcc 4.0 (from XCode 2.1).

Here are the options I used to build it :

--enable-application=browser 
--with-macos-sdk=/Developer/SDKs/MacOSX10.4u.sdk 
--enable-optimize=-O2 
--enable-prebinding 
--enable-canvas 
--disable-shared 
--enable-static 
--enable-svg 
--enable-macos-target=10.4 
--enable-strip 
--enable-update-packaging 
--disable-debug 
--disable-tests 
--disable-pedantic

Even if it comestic, it is not very great to see this.

No errors in JS Console to help :(

Comment 1

[Dave Townsend [:mossop]]

The new live bookmark icon apparently breaks all themes except the default,
please check with the default theme.

Comment 2

[Frederic Bezies]

Attachment: The button in the right side

Here is the display problem. Sorry if I entered a duplicate :(

Comment 3

[Frederic Bezies]

Seems to be the RSS button which is bad displayed. Related to bug 304426 also ?

Smells like my bug is invalid :(

Comment 4

[Frederic Bezies]

Renaming bug. Sorry for the spam :(

Whithout any graphical info on it, it is hard to guess what it is :(

Comment 5

[Dave Townsend [:mossop]]

Just realised that this was a mac report. bug 303848 comment 29 has the css
fixes for this.

Comment 6

[Frederic Bezies]

I will try the patch. What a pity it was not checked in before closing :(

Comment 7

[Frederic Bezies]

It works perfectly. The only point is related to the number of articles by feed,
but I will find it soon ;)

Comment 8

[Uri Bernstein]

Marking dependency on bug 303848 per comment #5.

Comment 9

[Gary Elshaw]

Attachment: rss button

There also seems to be a small problem with the button on secure sites. Note
the cutting-off of the button on the far right

Comment 10

[Tracy Walker [:tracy]]

In default theme, this blank button is always present. It shouldn't appear if
there isn't a news feed available. At secure sites, this button is covering up
the location bar "lock" icon.

Comment 11

[Asaf Romano (gone)]

I checked in Kevin's patch from bug 303848 (branch & trunk).

Comment 12

[Asaf Romano (gone)]

*** Bug 304597 has been marked as a duplicate of this bug. ***

Comment 13

[Kevin Gerich]

Thanks a lot Mano!

Comment 14

[Tracy Walker [:tracy]]

verified with Mac build 2005-08-16-05-mozilla1.8