304462 - popup blocked events don't have a message constant

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In bug 282103 comment 56, bryner says we fixed all event classes to have message
constants.  This isn't actually true for popupblocked events.  I had a fix for
this in some versions of my patch to bug 291725, but I didn't leave it in the
final version.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk 2005-08-26 14:38 -0700.

Comment 4

[Phil Ringnalda (:philor)]

This caused bug 306210

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I backed out the nsDOMEvent::SetEventType change until I can figure out why it
causes bug 306210.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the event listener manager doesn't know how to store listeners unless I
do the whole ArrayType / NS_EVENT_BITS dance.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Most of the rest backed out (except the nsEventListenerManager change and some
of the comment changes elsewhere).