304466 - SSL Icon for IMAP Accounts no longer shows up

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

Using 08/12 nightly. 

Turn on SSL for an imap account. Note that the SSL icon in the folder pane no
longer shows up like it used to for that account.

The CSS in the folder pane is looking for the isSecure property on the server.

It looks like we no longer set isSecure for imap, but instead set the socketType.

Comment 1

[Scott MacGregor]

To fix this properly, I suspect we should do the following:

1) Make nsMsgFolderDatasource listen for changes to the server's socket type
connection (to handle the case where we 'step up' to SSL).

2) Modify nsIMsgIncomingServer::IsSecure to reflect the real state of the
connection instead of looking at the obsolete connection type

3) When the connection changes from non secure to secure, the folder data source
can rebroadcast the isSecure attribute change out to the style system.

Comment 2

[Scott MacGregor]

Attachment: the fix

Instead of checking isSecure, look at the socket connection type and for SSL
and always TLS, it is safe to set the secure property on the server.

This restores us to 1.0.x behavior.

Comment 3

[Scott MacGregor]

fixed on the trunk

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 301114 has been marked as a duplicate of this bug. ***

Comment 5

[Scott MacGregor]

fixed branch and trunk

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

SeaMonkey build 2005-08-19-06
Thunderbird build version 1.6a1 (20050819)

on Windows XP.

Trunk verification only at this point.