304470 - bump Firefox version on Mozilla 1.8 branch to 1.4

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chase Phillips]

Bump Firefox version on Mozilla 1.8 branch to 1.4.

Comment 1

[Thorsten 'nightrat' Fritz]

This will be WONTFIX if the version in trunk would be changed to "1.5+" like
mentioned at https://bugzilla.mozilla.org/show_bug.cgi?id=304472#c1

Comment 2

[Chase Phillips]

If the trunk is one of 1.5+ or 1.6a1 how does that change the branch needing to
be bumped to 1.4?  I don't think it changes our story on the branch so I'm still
planning to bump it to 1.4 unless a solid opposing argument can be made.

Comment 3

[David B. Haun]

Retire the 1.0+ version number supporting 1.4 for the beta and 1.5 for the final
release.

Comment 4

[Chase Phillips]

This blocks 1.8b4.

Comment 5

[Scott MacGregor]

I'm going to do this for Chase.

Comment 6

[Grayson Mixon (ColdFusion650)]

shouldn't this be 1.3 now that they added another beta cycle? the roadmap says
that 1.5b will be 1.3. 1.5b2 will be 1.4.

Comment 7

[Scott MacGregor]

Attachment: the fix

changes for Firefox to go to 1.4.

Comment 8

[Chase Phillips]

Comment on attachment 194581 [details] [diff] [review]
the fix

Watch out for installer.cfg in installer/windows/ or installer/unix/.  One or
the other has the GRE version.	Probably best to just replace that value with
the appropriate autoconf variable so it gets auto-sub'd, too.

Comment 9

[Scott MacGregor]

Attachment: use the gecko milestone as the GRE Version

Benjamin, should be doing something like this to automatically generate the GRE
Version string or should we just update it by hand? In this case should we
change it from 1.7.5 to 1.8b4?

Note: I haven't fully tested this substitution yet. My build with this change
is still chugging but wanted to find out which direction you want us to go in.

Comment 10

[Scott MacGregor]

Benjamin, I'd love to bump the version today so we can get this off the radar if
you could advise me on what to do with the GRE Version. Thanks!

Comment 11

[Benjamin Smedberg]

As far as I can tell the GRE version really doesn't matter. As for the patch, I
don't understand where the $(MILESTONE) variable comes from.

Comment 12

[Scott MacGregor]

Comment on attachment 194592 [details] [diff] [review]
use the gecko milestone as the GRE Version

should we just leave it alone as 1.7.5 then? or change it to 1.8b4?

Comment 13

[Benjamin Smedberg]

Darin, do you know of a situation where we've used a "b" notation in the GRE
version before?

Comment 14

[Scott MacGregor]

I didn't want to keep the version change bottled up waiting for us to figure out
what to do with this GRE version in the installer, so I've gone ahead and landed
the 1.4 change tonight.

I'll continue to monitor the bug for suggestions about what to change the GRE
version.