304476 - remove app.extensions.version from firefox.js

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Chase Phillips]

Remove app.extensions.version from firefox.js on Mozilla 1.8 branch.

Comment 1

[Benjamin Smedberg]

Attachment: Pull extension min/maxversion numbers from the proper version.txt instead of hardcoding

The problem with any version number bump is that we have extensions all over
the tree that care a lot. So what I have done is always pull the firefox/tbird
version.txt, and make the current version of these apps always available via a
makefile var. Then we can bump the app+extension version number with a single
change to version.txt without worrying about the rest of the tree.

Comment 2

[Benjamin Smedberg]

BTW, this patch is for trunk and branch.

Comment 3

[Benjamin Smedberg]

Comment on attachment 192750 [details] [diff] [review]
Pull extension min/maxversion numbers from the proper version.txt instead of hardcoding

This is cycling on trunk now: low-risk if it builds ;-)

Comment 4

[Benjamin Smedberg]

Fixed on 1.8 branch also.

Comment 5

[Robert Strong (they/them - no direct email)]

I just downloaded Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050817 Firefox/1.0+ ID:2005081721 and the install.rdf's have
@FIREFOX_VERSION@ and @THUNDERBIRD_VERSION@ for minVersion and maxVersion. On
the trunk I see the appropriate minVersion and maxVersion for Firefox (e.g.
1.6a1) but the minVersion and maxVersion for Thunderbird is empty.

Side note: @FIREFOX_VERSION@ is not considered incompatible but that is a
different issue.

Comment 6

[Benjamin Smedberg]

(In reply to comment #5)
> I just downloaded Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
> Gecko/20050817 Firefox/1.0+ ID:2005081721 and the install.rdf's have
> @FIREFOX_VERSION@ and @THUNDERBIRD_VERSION@ for minVersion and maxVersion. On

This is because the 1.8 branch doesn't auto-commit configure :-(... I have
manually committed configure and this should be fixed.

> Side note: @FIREFOX_VERSION@ is not considered incompatible but that is a
> different issue.

It's not!? Do you know why? It should be interpreted as "0@FIREFOX_VERSION@"
which should be less than 1.4...

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to comment #6)
> It's not!? Do you know why? It should be interpreted as "0@FIREFOX_VERSION@"
> which should be less than 1.4...
I haven't had time to debug it yet due to having a hell of a week (lost a hard
drive on my dev system and my public web server within 2 days and other issues I
won't bore you with). I only had time to barely look into it and I am very sure
that @FIREFOX_VERSION@ was in both the install.rdf and extensions.rdf for these
items and they were enabled which infers compatibility. I should have time to
look into it more in the next day or two as long as lightning doesn't strike me.

Comment 8

[Robert Strong (they/them - no direct email)]

I forgot to reply that the reason they were not marked as incompatible was due
to one of the regressions that happened at the same time and is fixed.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This patch doesn't do the right thing for depend builds (see bug 330528 comment 4).