304504 - MOZCONFIG_MODULES duplicates entries

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brian Ryner (not reading)]

MOZCONFIG_MODULES in client.mk duplicates all of the modules/directories
assigned to it.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Was this caused by bug 304505? I don't understand why we're changing the
assignment mode or not-appending to mozconfig-modules.

Comment 3

[Brian Ryner (not reading)]

I noticed this problem when trying to pull minimo from the 1.8 branch... the 
line as-is in client.mk doesn't make much sense to me.  The point of the 
$(sort), as commented in the file, is to remove duplicates, but instead we're 
duplicating every item in MOZCONFIG_MODULES.

Comment 4

[Benjamin Smedberg]

Comment on attachment 192548 [details] [diff] [review]
patch

I prefer the solution in bug 304505

Comment 5

[Brian Ryner (not reading)]

We should take both patches... this line as it is serves no useful purpose.

Comment 6

[Benjamin Smedberg]

Are you sure you didn't mean to patch line 347? That's the call to $(sort),
which would make a lot more sense.

Comment 7

[Brian Ryner (not reading)]

Hah, you're right, that is what I meant to patch.  I think I misapplied this 
when I moved my patch over to the trunk.

Comment 8

[Brian Ryner (not reading)]

Attachment: real patch

This is what I meant to do, and what I actually verified fixed the minimo
problem on the 1.8 branch.  I just messed up when I manually applied the patch
to the trunk.

Comment 9

[Benjamin Smedberg]

Comment on attachment 192903 [details] [diff] [review]
real patch

Much better ;-)

Comment 10

[Brian Ryner (not reading)]

checked in on trunk and branch