Closed
Bug 304526
Opened 19 years ago
Closed 19 years ago
Upgrade to NSPR 4.6.1 Beta
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: wtc, Assigned: wtc)
Details
(Keywords: fixed1.8)
Attachments
(2 files)
20.87 KB,
patch
|
cbeard
:
approval1.8b4+
|
Details | Diff | Splinter Review |
1.55 KB,
patch
|
cls
:
review+
|
Details | Diff | Splinter Review |
The new Mozilla 1.8 branch is using NSPR 4.6 RTM. It should upgrade to NSPR 4.6.1 Beta, which has a few minor bug fixes.
Assignee | ||
Comment 1•19 years ago
|
||
For easier review by the drivers, I omitted changes to files that aren't used by Mozilla clients. Only two of these (7 and 8) are bug fixes. Everything else is build system/porting related. All the changes have been reviewed by me or Darin Fisher, or the experts in the areas (cls or Mac developers). 1. Changed NSPR version from "4.6" to "4.6.1 Beta". 2. Bug 298543: eliminated MACOS_DEPLOYMENT_TARGET. Replaced the environment variable by MACOSX_DEPLOYMENT_TARGET and the macro by MAC_OS_X_VERSION_MIN_REQUIRED. 3. Bug 290725: implemented USE_64 for Linux x86_64. Allows one to do 32-bit x86 builds on a 64-bit x86_64 system. 4. Bug 298674: RISC OS port. 5. Bug 303169: worked around a link error with gcc on Solaris SPARC in debug builds. 6. Bug 266123: Linux ppc64 (PowerPC 64-bit) port. 7. Bug 294017: make PR_NETADDR_SIZE return the correct value on Windows because Windows' struct in6_addr has different alignment from PRIPv6Addr. This bug only affected an assertion, which is only used in debug builds. 8. Bug 298612: ensure that the return value of StringGetChar, which is passed to isspace, etc., is EOF or between 0 and 255.
Attachment #192742 -
Flags: approval1.8b4?
Assignee | ||
Comment 2•19 years ago
|
||
1. Put the default value for --enable-macos-target in brackets after the description, which is the convention of our configure script. 2. Wrap long lines (--with-bthreads and --with-native-threads).
Attachment #192743 -
Flags: review?(cls)
Updated•19 years ago
|
Attachment #192742 -
Flags: approval1.8b4? → approval1.8b4+
Attachment #192743 -
Flags: review?(cls) → review+
Assignee | ||
Comment 3•19 years ago
|
||
I checked in the patches on the MOZILLA_1_8_BRANCH. Thanks. The "configure --help" message patch was also checked in on the NSPRPUB_PRE_4_2_CLIENT_BRANCH and NSPR trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha4
Assignee | ||
Updated•19 years ago
|
Target Milestone: mozilla1.8alpha4 → mozilla1.8beta4
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•