304567 - sort by calendar name fails

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20050813 Mozilla Sunbird/0.2+

Sorting events or tasks by calendar name does not sort.

Reproducible: Always

Steps to Reproduce:
0. create calendars with different names if necessary, and add events or tasks
to them.
1. enable calendar name column in event list and task list
2. click on column header


Actual Results:  
Not sorted by calendar name column.

Expected Results:  
Sorted by calendar name column.

Restarting sunbird produces empty task or event list with errors

Error: eventA.parent has no properties
Source File: chrome://calendar/content/unifinder.js
Line: 515

Error: taskA.parent has no properties
Source File: chrome://calendar/content/unifinderToDo.js
Line: 472

Comment 1

[gekacheka]

Looks like these were missed by bug 296318 that changed .parent to .calendar

Comment 2

[gekacheka]

Attachment: unifinders: item.parent --> item.calendar

(patch -l -p 2 -i file.patch)

fix references to item.parent to item.calendar

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 192621 [details] [diff] [review]
unifinders:  item.parent --> item.calendar

r=mvl

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in