Closed Bug 304588 Opened 19 years ago Closed 19 years ago

Remove 'use Bugzilla::User' from DB.pm

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Version:
2.20
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.22

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(1 file)

patch, v1
826 bytes, patch
mkanat
: review+
Details | Diff | Splinter Review 
User.pm is only required by the "obsolete" UserInGroup() routine. We can use
Bugzilla->user->in_group() instead.
Attached patch patch, v1 — — Splinter Review 

  

  



        Attachment #192648 -
        Flags: review?(mkanat)

    
    

    
  
Comment on attachment 192648 [details] [diff] [review]
patch, v1

Yep, obviously correct.

r=mkanat on inspection.

  

  



        Attachment #192648 -
        Flags: review?(mkanat) → review+

    
  
Status: NEW → ASSIGNED
Flags: approval?
Target Milestone: --- → Bugzilla 2.22

    
    

    
  
I'll re-run the module dependency graph after this is checked in and see how
many lines it removes. :)  (probably only one, oh well) 

  

  


Flags: approval? → approval+

    
    

    
  
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.63; previous revision: 1.62
done


  

  


Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: