304642 - Bugzilla::Flag::GetTarget() should be called internally by Bugzilla::Flag::process()

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Frédéric Buclin]

attachment.cgi:
line 1057:
  my $target = Bugzilla::Flag::GetTarget(undef, $attachid);
  Bugzilla::Flag::process($target, $timestamp, $cgi);

line 1206:
  my $target = Bugzilla::Flag::GetTarget(undef, $attach_id);
  Bugzilla::Flag::process($target, $timestamp, $cgi);


process_bug.cgi:
line 1738:
    my $target = Bugzilla::Flag::GetTarget($id);
    Bugzilla::Flag::process($target, $timestamp, $cgi);

process() should call GetTarget() itself. Its params are then:
Bugzilla::Flag::process($bug_id, $attach_id, $timestamp, $cgi);

I will also rename GetTarget() as get_target().

Note that with this change, get_target() will only be called from Flag.pm.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

I added a trivial test into process() to make sure the target object exists.
The remaining validations have been made by Bugzilla::Flag::validate().

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 192686 [details] [diff] [review]
patch, v1

looks good; r=myk

Comment 3

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.92; previous revision: 1.91
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.277; previous revision: 1.276
done
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.48; previous revision: 1.47
done