Crash when shutting down, related to toolbar buttons with a dropdown (back, forward, etc.)

RESOLVED FIXED

Status

()

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: aaronlev, Assigned: aaronlev)

Tracking

({access, crash, fixed1.8})

Trunk
x86
All
access, crash, fixed1.8
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: Have patch)

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
Occasionally I have seen a crash in ::Shutdown() for XUL button accessibles. The
cached first child is invalid. This is because we don't properly build up the
one possible drop marker child using ::CacheChildren() which is the new way of
doing things.
(Assignee)

Comment 1

13 years ago
Created attachment 192744 [details] [diff] [review]
Use CacheChildren() instead of overriding GetFirstChild() etc.
Attachment #192744 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #192744 - Flags: review?(parente)
(Assignee)

Updated

13 years ago
Attachment #192744 - Flags: review?(parente) → review?(timeless)

Updated

13 years ago
Attachment #192744 - Flags: review?(timeless) → review+
(Assignee)

Updated

13 years ago
Flags: blocking1.8b4?
Whiteboard: Have patch

Updated

13 years ago
Flags: blocking1.8b4? → blocking1.8b4+
Attachment #192744 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
(Assignee)

Updated

13 years ago
Attachment #192744 - Flags: approval1.8b4?

Updated

13 years ago
Attachment #192744 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.