304745 - Move GetFieldID() out of globals.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

Should go into Field.pm.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 194167 [details] [diff] [review]
patch, v1

checksetup.pl:1680:# Note that all of these entries are unconditional, from
when
 GetFieldID

Nit: Change also this comment reference?

>Index: Bugzilla/Field.pm
>===================================================================
>+=item C<get_field_id($fieldname)>
>+
>+Description: Returns the ID of the specified field name and throws
>+             an error if this field does not exist.

Nit: This sounds better with s/and/or/ and s/this field/the field name/.

>+Returns:     the corresponding field ID or an error if the field name
>+             does not exist.

Returns an error? Rather doesn't return at all.. Reword or maybe remove
everything after "or"? I won't hold review over POD but please fix this one
before commit.

>Index: template/en/default/global/user-error.html.tmpl
>===================================================================
>-  [% ELSIF error == "invalid_field_name" %]
>-    [% title = "Invalid Field Name" %]
>-    The field "[% name FILTER html %]" is invalid.
>-

Hmm, this is actually better error than the one actually used in the
corresponding code error. Looks like this error has never been used so this
doesn't affect this patch..

Comment 3

[Max Kanat-Alexander]

Also, I might prefer "field_name_to_id," to be clearer. :-) But it's up to you. :-)

Comment 4

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.96; previous revision: 1.95
done
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.435; previous revision: 1.434
done
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.103; previous revision: 1.102
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.339; previous revision: 1.338
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.94; previous revision: 1.93
done
Checking in Bugzilla/Field.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v  <--  Field.pm
new revision: 1.7; previous revision: 1.6
done
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.54; previous revision: 1.53
done
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.112; previous revision: 1.111
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.124; previous revision: 1.123
done