304749 - Give editors ability to delete comments

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Jon Stritar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

We need to let editors delete comments once again..

Reproducible: Always

Steps to Reproduce:

Comment 1

[Jon Stritar]

Attachment: Gives editors ability to remove comments.

Editors can now remove comments. This also sets the CommentVote to NULL when
you remove the comment. Run this SQL query to convert all the old deleted
comments to the style of the new ones:

UPDATE `feedback` SET `CommentTitle` = '<i>Removed by Staff</i>', `CommentVote`
= NULL WHERE `CommentTitle` = '<i>Removed by Admin</i>';

Comment 2

[alanjstr]

I don't see any change to the way votes are tabulated.  Does the vote counter
already ignore those where the vote value is not null?  Does the DB schema allow
nulls?

Comment 3

[alanjstr]

Also, the comment-manager queue has been kept relatively under control.  Why is
there a sudden need?

Part of the reason why editors cannot delete comments is that there is no
tracking of who deleted what.  

Comment 4

[Jon Stritar]

CTho and Morgamic wanted to give editors access to remove them again.

I didn't think about the rating updating... but if I remember correctly, CTho
checked in a patch recently to ignore ratings of comments that are removed, so
this should already be taken care of. I'll look into this tonight when I get a
chance.

Comment 5

[Jon Stritar]

I forgot to address one of your questions -

The NULL ratings are allowed in that column. When developers make "developer
comments", they are given NULL ratings. They appear just like the other comments
except with no star pictures.

Comment 6

[alanjstr]

Ok, then this is to explicitly back out CTho's work to remove it and at his
request.  

Comment 7

[alanjstr]

Attachment: Ignore based on vote value

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 194881 [details] [diff] [review]
Ignore based on vote value

Though LXR is out of date, the code in CVS does null the vote for deleted
comments, so r=cst.

Comment 9

[alanjstr]

Ok, my part still needs landing

Comment 10

[alanjstr]

Second patch landed now.  This is live.