<title> for Flag Type Created should include the name of the flag

RESOLVED FIXED in Bugzilla 3.4

Status

()

Bugzilla
Attachments & Requests
--
enhancement
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: timeless, Assigned: GavinS)

Tracking

2.19.1
Bugzilla 3.4
Bug Flags:
approval +

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

13 years ago
If I go on a flag creation spree and have 5-10 tabs/windows where i've created 
flags, i don't want them to all say "Flag Type Created".

expected results: <title> should include the flag name.

bonus points: the resulting page should include a link for format for printing 
(bug 304865).

Comment 2

12 years ago
Comment on attachment 251071 [details] [diff] [review]
patch for tip, overkill

>Index: editflagtypes.cgi

>+    $vars->{'id'}               = $id;
>+    $vars->{'name'}             = $name;
>+    $vars->{'description'}      = $description;
>+    $vars->{'cc_list'}          = $cc_list;
>+    $vars->{'target_type'}      = $target_type;
>+    $vars->{'sortkey'}          = $cgi->param('sortkey');
>+    $vars->{'is_active'}        = $cgi->param('is_active');
>+    $vars->{'is_multiplicable'} = $cgi->param('is_multiplicable');
>+    $vars->{'is_requestable'}   = $cgi->param('is_requestable');
>+    $vars->{'is_requesteeble'}  = $cgi->param('is_requesteeble');
>+    $vars->{'grant_gid'}        = scalar($cgi->param('grant_gid'));
>+    $vars->{'request_gid'}      = scalar($cgi->param('request_gid'));

Instead of passing each attribute individually, pass a flag type object.



>--- /dev/null	2007-01-10 23:15:32.326030400 +0900
>+++ template/en/default/admin/flag-type/created.html.tmpl	2007-01-10 

Do not create another "intermediate" page. Better is to return to the "edit" page directly.

Moreover, this bug is only about adding the flag type name in the title of the page, nothing else (see the reference bug given in comment 0).
Attachment #251071 - Flags: review? → review-
(Assignee)

Comment 3

10 years ago
Created attachment 321668 [details] [diff] [review]
Add flag type name to <title>
Attachment #321668 - Flags: review?

Comment 4

10 years ago
The patch itself is fine, but why should we display the flag name in the title while we don't do it for other fields (products, components, etc...)?
(In reply to comment #2)
> Instead of passing each attribute individually, pass a flag type object.

Do we have a flag type object to pass at that point?  If not, there's no sense in creating one just to pass it to a template that's only looking for the name...  On the other hand, if we've already created an object at that point, we should certainly pass it so people customizing the template can have access to it.

(In reply to comment #4)
> The patch itself is fine, but why should we display the flag name in the title
> while we don't do it for other fields (products, components, etc...)?

We probably should, and those ought to be separate bugs.

Comment 6

10 years ago
Comment on attachment 321668 [details] [diff] [review]
Add flag type name to <title> 

r=LpSolit
Attachment #321668 - Flags: review? → review+

Updated

10 years ago
Assignee: attach-and-request → bugzilla
Flags: approval+
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 3.4

Comment 7

10 years ago
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v  <--  messages.html.tmpl
new revision: 1.75; previous revision: 1.74
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.