304889 - Templatize reports.cgi

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, enhancement)

Description

[A. Karl Kornel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)

Reports.cgi is not templatized, and probably should be!

Reproducible: Didn't try

Steps to Reproduce:

Comment 1

[Gervase Markham [:gerv]]

No, it shouldn't be - it's deprecated in favour of report.cgi. As soon as we fix
that up properly, reports.cgi is going away. It should have gone away in 2.20,
but I didn't get around to it.

Gerv

Comment 2

[Dave Miller [:justdave]]

(In reply to comment #1)
> No, it shouldn't be - it's deprecated in favour of report.cgi. As soon as we
> fix that up properly, reports.cgi is going away.

It's 11 months later and it's still not gone.  Templatizing it will be fairly easy I'd imagine, compared to some of the other stuff we've been doing lately.  Let's go ahead and do it just in case.  Hopefully the effort is wasted, but if it's not, I'd rather be safe than sorry, and it's the last piece of non-localizable code left.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Comment 4

[Max Kanat-Alexander]

Comment on attachment 230601 [details] [diff] [review]
patch, v1

Looks fine to me. I just looked over it briefly, and I didn't test it, but the idea seems good and things look right.

Comment 5

[Frédéric Buclin]

Checking in reports.cgi;
/cvsroot/mozilla/webtools/bugzilla/reports.cgi,v  <--  reports.cgi
new revision: 1.89; previous revision: 1.88
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/old-charts.html.tmpl,v
done
Checking in template/en/default/reports/old-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/old-charts.html.tmpl,v  <--  old-charts.html.tmpl
initial revision: 1.1
done