Closed
Bug 304928
Opened 20 years ago
Closed 20 years ago
select1 will not select the last item in its list
Categories
(Core Graveyard :: XForms, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aaronr, Assigned: aaronr)
Details
(Keywords: fixed1.8)
Attachments
(2 files)
|
1.36 KB,
application/xhtml+xml
|
Details | |
|
1.10 KB,
patch
|
smaug
:
review+
allan
:
review+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Assume that you have a select1 containing an itemset. If the instance data is
such that the last item in the select1's list of options should be initialized
as selected, then the select1 will not show any selected item. Looks like it is
because of the 'while' loop in nsXFormsItemSetElement::SelectItemByValue. It
will never get to go through all of the child nodes fine, but since it is
initializing the variable selectChild off of the variable tmp (which is
uninitialized to begin with) then the call to SelectItemByValue is always the
previous sibling to child and thus the last child will never be looked at.
testcase that shows the problem. The initial selected value in the select1
should be '45'.
quick fix. Just using child to create selectChild instead of tmp.
Attachment #192910 -
Flags: superreview?(allan)
Attachment #192910 -
Flags: review?(smaug)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 192910 [details] [diff] [review]
fix
oops :)
Attachment #192910 -
Flags: superreview?(allan)
Attachment #192910 -
Flags: review?(smaug)
Attachment #192910 -
Flags: review?(allan)
Attachment #192910 -
Flags: review+
|
||
Updated•20 years ago
|
Attachment #192910 -
Flags: review?(allan) → review+
Attachment #192910 -
Flags: approval1.8b4?
|
||
Comment 4•20 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•20 years ago
|
||
Reopening so that we don't forget to check this in to branch too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•20 years ago
|
Whiteboard: xf-to-branch
|
||
Updated•20 years ago
|
Attachment #192910 -
Flags: approval1.8b4? → approval1.8b4+
|
|
||
Comment 6•20 years ago
|
||
Comment on attachment 192910 [details] [diff] [review]
fix
in order to land on the branch, this needs to be resolved then verified on the
trunk.
Attachment #192910 -
Flags: approval1.8b4+ → approval1.8b4?
This has already been checked/verified on trunk.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
|
|
||
Updated•20 years ago
|
Status: RESOLVED → VERIFIED
|
|
||
Updated•20 years ago
|
Attachment #192910 -
Flags: approval1.8b4? → approval1.8b4+
|
|
||
Comment 8•20 years ago
|
||
Time is short for 1.8b4. If this isn't landed today, it's not going to make the
train.
|
||
Comment 10•20 years ago
|
||
is the testcase broken? I'm not seeing a select form list with any browser.
|
Assignee | |
Comment 11•20 years ago
|
||
(In reply to comment #10)
> is the testcase broken? I'm not seeing a select form list with any browser.
did you install the XForms extension (xforms.xpi)? The fix is contained in our
extension
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•