304978 - multiple windows with multiple tabs on update = can't close

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Joe Drew (not getting mail)]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050816 Firefox/1.0+

I had multiple windows open on multiple workspaces, each of which had multiple
tabs. (In short, multiple windows, only one of which was visible to me at the
time.) Deer Park prompted me to restart because an update had been installed
(first time I've seen the autoupdate, and it works!), and I clicked "Restart,"
but nothing happened. I clicked a bunch more times and still nothing happened,
so I closed the window and it said the update would be installed when I
restarted. Then I checked my other window, on another workspace, and I had a
bunch of windows saying "Do you want to close this window, as you have multiple
tabs open."

In an ideal world, you'd get a window which was parented to the update window
(so it would appear on the same workspace), saying "You have multiple
windows/multiple tabs open, do you want to close all of them and restart?"
Answering affirmatively would close ALL windows without prompting on them.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

The other, probably more containable possibility is to just make the restart
warning dialog say "this will close all windows and tabs" and not have those
modal dialogs pop up.

Yet another, and the best solution, would be to have the user session restart
after update exactly where they left off. Same tabs, same windows, etc. That's a
lot harder, of course, but boy, it'd be nice.

Comment 2

[Michael]

When I click on the X in the upper right corner, the "Warning" that says I am closing (whatever amount- 3 tabs for example) flashes, but goes away, not giving me time to click yes or no. I have to close each tab individually. I have re-down loaded FF, I have done upgrades. Still have the problem.

Comment 3

[Robert Strong (they/them - no direct email)]

The closing of the windows and the dialog are both part of Firefox and not app update. Also, I highly suspect the same thing occurs when doing a restart from the add-ons manager.

http://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#283

Comment 4

[:Gijs (he/him)]

We no longer prompt in this way when restarting for updates, marking WFM. Please reopen if this is still an issue in some way.